RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:07:35 +00:00
Code Issues Activity Actions

LibWeb: Layout viewport rect was lagging behind when resizing

Browse source 
Layout was using an outdated viewport rect that we set *after* doing
a layout due to resize. That meant that layout-in-response-to-resize
was always lagging behind the current size of the view.

The root of this problem was how Frame kept both a viewport rect
(with both scroll offset and size) and a frame size. To fix this,
only store the viewport scroll offset, and always use the frame size.
This way they can't get out of sync and the problem goes away. :^)

Fixes #4250.
This commit is contained in:
Andreas Kling 2020-12-02 23:40:57 +01:00
parent 766db673c1
commit 15e35b0d71
4 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Services/WebContent/PageHost.cpp
View file

@ -103,7 +103,7 @@ void PageHost::set_viewport_rect(const Gfx::IntRect& rect)
page().main_frame().set_size(rect.size());
if (page().main_frame().document())
page().main_frame().document()->layout();
page().main_frame().set_viewport_rect(rect);
page().main_frame().set_viewport_scroll_offset(rect.location());
}
void PageHost::page_did_invalidate(const Gfx::IntRect& content_rect)