RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:17:46 +00:00
Code Issues Activity Actions

AK+Everywhere: Delete Variant's default constructor

Browse source 
This was exposed to the user by mistake, and even accumulated a bunch of
users that didn't blow up out of sheer luck.
This commit is contained in:
Ali Mohammad Pur 2021-08-13 17:31:39 +04:30
parent 90e6b9d453
commit 15f95220ae
6 changed files with 29 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibSQL/Value.cpp
View file

@ -10,11 +10,13 @@
namespace SQL {
Value::Value(SQLType sql_type)
: m_impl(0)
{
setup(sql_type);
}
Value::Value(SQLType sql_type, ByteBuffer& buffer, size_t& offset)
: m_impl(0)
{
setup(sql_type);
m_deserialize(buffer, offset);
@ -22,6 +24,7 @@ Value::Value(SQLType sql_type, ByteBuffer& buffer, size_t& offset)
}
Value::Value(Value const& other)
: m_impl(0)
{
setup(other.type());
m_is_null = other.is_null();

2
Userland/Libraries/LibSQL/Value.h
View file

@ -102,7 +102,7 @@ private:
SQLType m_type { SQLType::Text };
bool m_is_null { true };
Variant<String, int, double> m_impl {};
Variant<String, int, double> m_impl;
};
}