RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 16:57:36 +00:00
Code Issues Activity Actions

Applications: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-10 12:28:48 -07:00 • committed by Linus Groh
parent 6be75bd5e4
commit 160bda7228
195 changed files with 335 additions and 638 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Applications/Calculator/Calculator.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -9,14 +10,6 @@
#include <AK/Assertions.h>
#include <AK/Math.h>
Calculator::Calculator()
{
}
Calculator::~Calculator()
{
}
KeypadValue Calculator::begin_operation(Operation operation, KeypadValue argument)
{
KeypadValue res = 0;

5
Userland/Applications/Calculator/Calculator.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -17,8 +18,8 @@
class Calculator final {
public:
Calculator();
~Calculator();
Calculator() = default;
~Calculator() = default;
enum class Operation {
None,

5
Userland/Applications/Calculator/CalculatorWidget.cpp
View file

@ -2,6 +2,7 @@
* Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
* Copyright (c) 2021, Glenford Williams <gw_dev@outlook.com>
* Copyright (c) 2021, Max Wipfli <mail@maxwipfli.ch>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -104,10 +105,6 @@ CalculatorWidget::CalculatorWidget()
};
}
CalculatorWidget::~CalculatorWidget()
{
}
void CalculatorWidget::add_operation_button(GUI::Button& button, Calculator::Operation operation)
{
button.on_click = [this, operation](auto) {

3
Userland/Applications/Calculator/CalculatorWidget.h
View file

@ -1,6 +1,7 @@
/*
* Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
* Copyright (c) 2021, Glenford Williams <gw_dev@outlook.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -16,7 +17,7 @@
class CalculatorWidget final : public GUI::Widget {
C_OBJECT(CalculatorWidget)
public:
virtual ~CalculatorWidget() override;
virtual ~CalculatorWidget() override = default;
String get_entry();
void set_entry(KeypadValue);

9
Userland/Applications/Calculator/Keypad.cpp
View file

@ -1,6 +1,7 @@
/*
* Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
* Copyright (c) 2021, Max Wipfli <mail@maxwipfli.ch>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -10,14 +11,6 @@
#include <AK/IntegralMath.h>
#include <AK/StringBuilder.h>
Keypad::Keypad()
{
}
Keypad::~Keypad()
{
}
void Keypad::type_digit(int digit)
{
u64 previous_value = 0;

5
Userland/Applications/Calculator/Keypad.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -16,8 +17,8 @@
class Keypad final {
public:
Keypad();
~Keypad();
Keypad() = default;
~Keypad() = default;
void type_digit(int digit);
void type_decimal_point();