RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 02:37:35 +00:00
Code Issues Activity Actions

Applications: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-10 12:28:48 -07:00 • committed by Linus Groh
parent 6be75bd5e4
commit 160bda7228
195 changed files with 335 additions and 638 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Applications/CharacterMap/CharacterMapWidget.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -123,10 +124,6 @@ CharacterMapWidget::CharacterMapWidget()
update_statusbar();
}
CharacterMapWidget::~CharacterMapWidget()
{
}
void CharacterMapWidget::initialize_menubar(GUI::Window& window)
{
auto& file_menu = window.add_menu("&File");

3
Userland/Applications/CharacterMap/CharacterMapWidget.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -14,7 +15,7 @@ class CharacterMapWidget final : public GUI::Widget {
C_OBJECT(CharacterMapWidget);
public:
virtual ~CharacterMapWidget() override;
virtual ~CharacterMapWidget() override = default;
void initialize_menubar(GUI::Window& window);

7
Userland/Applications/CharacterMap/CharacterSearchWidget.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -16,7 +17,7 @@ struct SearchResult {
class CharacterSearchModel final : public GUI::Model {
public:
CharacterSearchModel() { }
CharacterSearchModel() = default;
int row_count(GUI::ModelIndex const&) const override { return m_data.size(); }
int column_count(GUI::ModelIndex const&) const override { return 2; }
@ -72,10 +73,6 @@ CharacterSearchWidget::CharacterSearchWidget()
};
}
CharacterSearchWidget::~CharacterSearchWidget()
{
}
void CharacterSearchWidget::search()
{
// TODO: Sort the results nicely. They're sorted by code-point for now, which is easy, but not the most useful.

3
Userland/Applications/CharacterMap/CharacterSearchWidget.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -15,7 +16,7 @@ class CharacterSearchWidget final : public GUI::Widget {
C_OBJECT(CharacterSearchWidget);
public:
virtual ~CharacterSearchWidget() override;
virtual ~CharacterSearchWidget() override = default;
Function<void(u32)> on_character_selected;