RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 15:17:46 +00:00
Code Issues Activity Actions

Applications: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-10 12:28:48 -07:00 • committed by Linus Groh
parent 6be75bd5e4
commit 160bda7228
195 changed files with 335 additions and 638 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Applications/DisplaySettings/BackgroundSettingsWidget.cpp
View file

@ -1,6 +1,7 @@
/*
* Copyright (c) 2019-2020, Jesse Buhagiar <jooster669@gmail.com>
* Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -40,10 +41,6 @@ BackgroundSettingsWidget::BackgroundSettingsWidget()
load_current_settings();
}
BackgroundSettingsWidget::~BackgroundSettingsWidget()
{
}
void BackgroundSettingsWidget::create_frame()
{
load_from_gml(background_settings_gml);

3
Userland/Applications/DisplaySettings/BackgroundSettingsWidget.h
View file

@ -1,6 +1,7 @@
/*
* Copyright (c) 2019-2020, Jesse Buhagiar <jooster669@gmail.com>
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -21,7 +22,7 @@ class BackgroundSettingsWidget : public GUI::SettingsWindow::Tab {
C_OBJECT(BackgroundSettingsWidget);
public:
virtual ~BackgroundSettingsWidget() override;
virtual ~BackgroundSettingsWidget() override = default;
virtual void apply_settings() override;

6
Userland/Applications/DisplaySettings/DesktopSettingsWidget.cpp
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2020-2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -21,10 +21,6 @@ DesktopSettingsWidget::DesktopSettingsWidget()
load_current_settings();
}
DesktopSettingsWidget::~DesktopSettingsWidget()
{
}
void DesktopSettingsWidget::create_frame()
{
load_from_gml(desktop_settings_gml);

4
Userland/Applications/DisplaySettings/DesktopSettingsWidget.h
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2020-2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -16,7 +16,7 @@ class DesktopSettingsWidget : public GUI::SettingsWindow::Tab {
C_OBJECT(DesktopSettingsWidget);
public:
virtual ~DesktopSettingsWidget() override;
virtual ~DesktopSettingsWidget() override = default;
virtual void apply_settings() override;

5
Userland/Applications/DisplaySettings/FontSettingsWidget.cpp
View file

@ -1,6 +1,7 @@
/*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2021, Thomas Keppler <winfr34k@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -45,10 +46,6 @@ FontSettingsWidget::FontSettingsWidget()
};
}
FontSettingsWidget::~FontSettingsWidget()
{
}
static void update_label_with_font(GUI::Label& label, Gfx::Font const& font)
{
label.set_text(font.human_readable_name());

3
Userland/Applications/DisplaySettings/FontSettingsWidget.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -15,7 +16,7 @@ class FontSettingsWidget final : public GUI::SettingsWindow::Tab {
C_OBJECT(FontSettingsWidget);
public:
virtual ~FontSettingsWidget() override;
virtual ~FontSettingsWidget() override = default;
virtual void apply_settings() override;