mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 20:27:46 +00:00
Applications: Use default constructors/destructors
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules "The compiler is more likely to get the default semantics right and you cannot implement these functions better than the compiler."
This commit is contained in:
parent
6be75bd5e4
commit
160bda7228
195 changed files with 335 additions and 638 deletions
|
@ -1,6 +1,7 @@
|
|||
/*
|
||||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -17,10 +18,6 @@ KeysWidget::KeysWidget(TrackManager& track_manager)
|
|||
set_fill_with_background_color(true);
|
||||
}
|
||||
|
||||
KeysWidget::~KeysWidget()
|
||||
{
|
||||
}
|
||||
|
||||
int KeysWidget::mouse_note() const
|
||||
{
|
||||
if (m_mouse_down && m_mouse_note + m_track_manager.octave_base() < note_count)
|
||||
|
|
|
@ -1,6 +1,7 @@
|
|||
/*
|
||||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -15,7 +16,7 @@ class TrackManager;
|
|||
class KeysWidget final : public GUI::Frame {
|
||||
C_OBJECT(KeysWidget)
|
||||
public:
|
||||
virtual ~KeysWidget() override;
|
||||
virtual ~KeysWidget() override = default;
|
||||
|
||||
int key_code_to_key(int key_code) const;
|
||||
int mouse_note() const;
|
||||
|
|
|
@ -1,6 +1,7 @@
|
|||
/*
|
||||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -103,10 +104,6 @@ KnobsWidget::KnobsWidget(TrackManager& track_manager, MainWidget& main_widget)
|
|||
}
|
||||
}
|
||||
|
||||
KnobsWidget::~KnobsWidget()
|
||||
{
|
||||
}
|
||||
|
||||
void KnobsWidget::cycle_waveform()
|
||||
{
|
||||
m_synth_waveform->set_selected_index((m_synth_waveform->selected_index() + 1) % m_synth_waveform->model()->row_count());
|
||||
|
|
|
@ -1,6 +1,7 @@
|
|||
/*
|
||||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -22,7 +23,7 @@ class MainWidget;
|
|||
class KnobsWidget final : public GUI::Frame {
|
||||
C_OBJECT(KnobsWidget)
|
||||
public:
|
||||
virtual ~KnobsWidget() override;
|
||||
virtual ~KnobsWidget() override = default;
|
||||
|
||||
void update_knobs();
|
||||
void cycle_waveform();
|
||||
|
|
|
@ -1,6 +1,7 @@
|
|||
/*
|
||||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -52,10 +53,6 @@ MainWidget::MainWidget(TrackManager& track_manager, AudioPlayerLoop& loop)
|
|||
m_roll_widget->set_keys_widget(m_keys_widget);
|
||||
}
|
||||
|
||||
MainWidget::~MainWidget()
|
||||
{
|
||||
}
|
||||
|
||||
void MainWidget::add_track_actions(GUI::Menu& menu)
|
||||
{
|
||||
menu.add_action(GUI::Action::create("&Add Track", { Mod_Ctrl, Key_T }, [&](auto&) {
|
||||
|
|
|
@ -2,6 +2,7 @@
|
|||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -23,7 +24,7 @@ class PlayerWidget;
|
|||
class MainWidget final : public GUI::Widget {
|
||||
C_OBJECT(MainWidget)
|
||||
public:
|
||||
virtual ~MainWidget() override;
|
||||
virtual ~MainWidget() override = default;
|
||||
|
||||
void add_track_actions(GUI::Menu&);
|
||||
|
||||
|
|
|
@ -1,5 +1,6 @@
|
|||
/*
|
||||
* Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -95,10 +96,6 @@ PlayerWidget::PlayerWidget(TrackManager& manager, AudioPlayerLoop& loop)
|
|||
};
|
||||
}
|
||||
|
||||
PlayerWidget::~PlayerWidget()
|
||||
{
|
||||
}
|
||||
|
||||
void PlayerWidget::add_track()
|
||||
{
|
||||
m_track_manager.add_track();
|
||||
|
|
|
@ -1,5 +1,6 @@
|
|||
/*
|
||||
* Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -14,7 +15,7 @@ class TrackManager;
|
|||
class PlayerWidget final : public GUI::Toolbar {
|
||||
C_OBJECT(PlayerWidget)
|
||||
public:
|
||||
virtual ~PlayerWidget() override;
|
||||
virtual ~PlayerWidget() override = default;
|
||||
|
||||
void add_track();
|
||||
void next_track();
|
||||
|
|
|
@ -2,6 +2,7 @@
|
|||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -28,10 +29,6 @@ RollWidget::RollWidget(TrackManager& track_manager)
|
|||
vertical_scrollbar().set_value(roll_height / 2);
|
||||
}
|
||||
|
||||
RollWidget::~RollWidget()
|
||||
{
|
||||
}
|
||||
|
||||
void RollWidget::paint_event(GUI::PaintEvent& event)
|
||||
{
|
||||
m_roll_width = widget_inner_rect().width() * m_zoom_level;
|
||||
|
|
|
@ -2,6 +2,7 @@
|
|||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -19,7 +20,7 @@ using LibDSP::RollNote;
|
|||
class RollWidget final : public GUI::AbstractScrollableWidget {
|
||||
C_OBJECT(RollWidget)
|
||||
public:
|
||||
virtual ~RollWidget() override;
|
||||
virtual ~RollWidget() override = default;
|
||||
|
||||
const KeysWidget* keys_widget() const { return m_keys_widget; }
|
||||
void set_keys_widget(const KeysWidget* widget) { m_keys_widget = widget; }
|
||||
|
|
|
@ -1,5 +1,6 @@
|
|||
/*
|
||||
* Copyright (c) 2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -18,10 +19,6 @@ WaveEditor::WaveEditor(TrackManager& track_manager)
|
|||
{
|
||||
}
|
||||
|
||||
WaveEditor::~WaveEditor()
|
||||
{
|
||||
}
|
||||
|
||||
int WaveEditor::sample_to_y(double percentage) const
|
||||
{
|
||||
double portion_of_half_height = percentage * ((frame_inner_rect().height() - 1) / 2.0);
|
||||
|
@ -100,7 +97,3 @@ SamplerWidget::SamplerWidget(TrackManager& track_manager)
|
|||
m_wave_editor = add<WaveEditor>(m_track_manager);
|
||||
m_wave_editor->set_fixed_height(100);
|
||||
}
|
||||
|
||||
SamplerWidget::~SamplerWidget()
|
||||
{
|
||||
}
|
||||
|
|
|
@ -1,5 +1,6 @@
|
|||
/*
|
||||
* Copyright (c) 2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -13,7 +14,7 @@ class TrackManager;
|
|||
class WaveEditor final : public GUI::Frame {
|
||||
C_OBJECT(WaveEditor)
|
||||
public:
|
||||
virtual ~WaveEditor() override;
|
||||
virtual ~WaveEditor() override = default;
|
||||
|
||||
private:
|
||||
explicit WaveEditor(TrackManager&);
|
||||
|
@ -28,7 +29,7 @@ private:
|
|||
class SamplerWidget final : public GUI::Frame {
|
||||
C_OBJECT(SamplerWidget)
|
||||
public:
|
||||
virtual ~SamplerWidget() override;
|
||||
virtual ~SamplerWidget() override = default;
|
||||
|
||||
private:
|
||||
explicit SamplerWidget(TrackManager&);
|
||||
|
|
|
@ -2,6 +2,7 @@
|
|||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -24,10 +25,6 @@ Track::Track(const u32& time)
|
|||
set_volume(volume_max);
|
||||
}
|
||||
|
||||
Track::~Track()
|
||||
{
|
||||
}
|
||||
|
||||
void Track::fill_sample(Sample& sample)
|
||||
{
|
||||
m_temporary_transport->time() = m_time;
|
||||
|
|
|
@ -2,6 +2,7 @@
|
|||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -26,7 +27,7 @@ class Track {
|
|||
|
||||
public:
|
||||
explicit Track(const u32& time);
|
||||
~Track();
|
||||
~Track() = default;
|
||||
|
||||
const Vector<Audio::Sample>& recorded_sample() const { return m_recorded_sample; }
|
||||
const SinglyLinkedList<RollNote>& roll_notes(int note) const { return m_roll_notes[note]; }
|
||||
|
|
|
@ -2,6 +2,7 @@
|
|||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -14,10 +15,6 @@ TrackManager::TrackManager()
|
|||
add_track();
|
||||
}
|
||||
|
||||
TrackManager::~TrackManager()
|
||||
{
|
||||
}
|
||||
|
||||
void TrackManager::time_forward(int amount)
|
||||
{
|
||||
int new_value = (static_cast<int>(m_time) + amount) % roll_length;
|
||||
|
|
|
@ -2,6 +2,7 @@
|
|||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -21,7 +22,7 @@ class TrackManager {
|
|||
|
||||
public:
|
||||
TrackManager();
|
||||
~TrackManager();
|
||||
~TrackManager() = default;
|
||||
|
||||
Track& current_track() { return *m_tracks[m_current_track]; }
|
||||
Span<const Sample> buffer() const { return m_current_front_buffer; }
|
||||
|
|
|
@ -1,6 +1,7 @@
|
|||
/*
|
||||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -15,10 +16,6 @@ WaveWidget::WaveWidget(TrackManager& track_manager)
|
|||
{
|
||||
}
|
||||
|
||||
WaveWidget::~WaveWidget()
|
||||
{
|
||||
}
|
||||
|
||||
int WaveWidget::sample_to_y(int sample) const
|
||||
{
|
||||
constexpr int nice_scale_factor = 4;
|
||||
|
|
|
@ -1,6 +1,7 @@
|
|||
/*
|
||||
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
|
||||
* Copyright (c) 2022, the SerenityOS developers.
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -14,7 +15,7 @@ class TrackManager;
|
|||
class WaveWidget final : public GUI::Frame {
|
||||
C_OBJECT(WaveWidget)
|
||||
public:
|
||||
virtual ~WaveWidget() override;
|
||||
virtual ~WaveWidget() override = default;
|
||||
|
||||
private:
|
||||
explicit WaveWidget(TrackManager&);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue