From 162c33450862d4bd5b35c9fd3b548da618b560bd Mon Sep 17 00:00:00 2001 From: Andrew Kaster Date: Sun, 14 Jan 2024 15:51:32 -0700 Subject: [PATCH] Revert "Assistant: Check for access before showing results" This reverts commit 7c88ab2836b87cb19620830cfc1c2475228671c2. Post-merge review revealed that the checks added in this PR prevent any and all non-executable files from being displayed in Assistant, which is a regression from intended functionality. --- Userland/Applications/Assistant/Providers.cpp | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/Userland/Applications/Assistant/Providers.cpp b/Userland/Applications/Assistant/Providers.cpp index 247ad1b7b4..11c5e85c4d 100644 --- a/Userland/Applications/Assistant/Providers.cpp +++ b/Userland/Applications/Assistant/Providers.cpp @@ -66,9 +66,7 @@ void URLResult::activate() const AppProvider::AppProvider() { Desktop::AppFile::for_each([this](NonnullRefPtr app_file) { - if (access(app_file->executable().characters(), X_OK) == 0) { - m_app_file_cache.append(move(app_file)); - } + m_app_file_cache.append(move(app_file)); }); } @@ -226,10 +224,6 @@ void FileProvider::build_filesystem_cache() return IterationDecision::Continue; auto full_path = LexicalPath::join(directory.path().string(), entry.name).string(); - - if (access(full_path.characters(), X_OK) != 0) - return IterationDecision::Continue; - m_full_path_cache.append(full_path); if (S_ISDIR(st.st_mode)) {