RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 01:17:46 +00:00
Code Issues Activity Actions

AK: Resolve clang-tidy warnings about unusual assignment operators

Browse source 
Either not returning *this, or in the case of Variant, not checking for
self assignment. In AK::Atomic, we can't return *this due to the wrapper
semantics Atomic implements.
This commit is contained in:
Andrew Kaster 2021-10-31 14:52:26 -06:00 • committed by Andreas Kling
parent 22feb9d47b
commit 163367da39
3 changed files with 17 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

20
AK/Variant.h
View file

@ -271,11 +271,13 @@ public:
requires(!(IsTriviallyCopyConstructible<Ts> && ...) || !(IsTriviallyDestructible<Ts> && ...))
#endif
{
if constexpr (!(IsTriviallyDestructible<Ts> && ...)) {
Helper::delete_(m_index, m_data);
if (this != &other) {
if constexpr (!(IsTriviallyDestructible<Ts> && ...)) {
Helper::delete_(m_index, m_data);
}
m_index = other.m_index;
Helper::copy_(other.m_index, other.m_data, m_data);
}
m_index = other.m_index;
Helper::copy_(other.m_index, other.m_data, m_data);
return *this;
}
@ -284,11 +286,13 @@ public:
requires(!(IsTriviallyMoveConstructible<Ts> && ...) || !(IsTriviallyDestructible<Ts> && ...))
#endif
{
if constexpr (!(IsTriviallyDestructible<Ts> && ...)) {
Helper::delete_(m_index, m_data);
if (this != &other) {
if constexpr (!(IsTriviallyDestructible<Ts> && ...)) {
Helper::delete_(m_index, m_data);
}
m_index = other.m_index;
Helper::move_(other.m_index, other.m_data, m_data);
}
m_index = other.m_index;
Helper::move_(other.m_index, other.m_data, m_data);
return *this;
}