RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:37:44 +00:00
Code Issues Activity Actions

Kernel: Remove big lock from sys$set_coredump_metadata

Browse source 
The only requirement for this syscall is to make
Process::m_coredump_properties SpinlockProtected.
This commit is contained in:
Luke Wilde 2022-04-09 18:30:20 +01:00 • committed by Andreas Kling
parent 343aec2200
commit 1682b0b6d8
5 changed files with 25 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Kernel/Syscalls/execve.cpp
View file

@ -525,8 +525,9 @@ ErrorOr<void> Process::do_exec(NonnullRefPtr<OpenFileDescription> main_program_d
return {};
}));
for (auto& property : m_coredump_properties)
m_coredump_properties.for_each([](auto& property) {
property = {};
});
auto* current_thread = Thread::current();
current_thread->reset_signals_for_exec();

2
Kernel/Syscalls/process.cpp
View file

@ -50,7 +50,7 @@ ErrorOr<FlatPtr> Process::sys$set_process_name(Userspace<char const*> user_name,
ErrorOr<FlatPtr> Process::sys$set_coredump_metadata(Userspace<Syscall::SC_set_coredump_metadata_params const*> user_params)
{
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this)
VERIFY_NO_PROCESS_BIG_LOCK(this)
auto params = TRY(copy_typed_from_user(user_params));
if (params.key.length == 0 || params.key.length > 16 * KiB)