RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:47:34 +00:00
Code Issues Activity Actions

Shell: Do not try to recreate a command from a list of args in time

Browse source 
Shell already provides a run_command(AST::Command) which can be
constructed from a list of arguments, use that instead.
This commit is contained in:
AnotherTest 2020-06-19 16:32:19 +04:30 • committed by Andreas Kling
parent bc3285abb0
commit 16def040af
1 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Shell/Builtin.cpp
View file

@ -654,15 +654,18 @@ int Shell::builtin_time(int argc, const char** argv)
if (!parser.parse(argc, const_cast<char**>(argv), false)) if (!parser.parse(argc, const_cast<char**>(argv), false))
return 1; return 1;
StringBuilder builder; AST::Command command;
builder.join(' ', args); for (auto& arg : args)
command.argv.append(arg);
Core::ElapsedTimer timer; Core::ElapsedTimer timer;
timer.start(); timer.start();
// TODO: Exit code auto job = run_command(command);
run_command(builder.string_view()); if (!job)
return 1;
block_on_job(job);
fprintf(stderr, "Time: %d ms\n", timer.elapsed()); fprintf(stderr, "Time: %d ms\n", timer.elapsed());
return 0; return job->exit_code();
} }
int Shell::builtin_umask(int argc, const char** argv) int Shell::builtin_umask(int argc, const char** argv)