RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 22:48:11 +00:00
Code Issues Activity Actions

TextEditor: Fix passing null parent to AboutDialog

Browse source 
Refactors menubar creation to avoid passing a null parent window
to AboutDialog during construction. Fixes #5177 in part
This commit is contained in:
thankyouverycool 2021-02-26 07:16:40 -05:00 • committed by Andreas Kling
parent 2481dbcc41
commit 1723eac40f
3 changed files with 39 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Applications/TextEditor/TextEditorWidget.h
View file

@ -55,6 +55,7 @@ public:
void set_auto_detect_preview_mode(bool value) { m_auto_detect_preview_mode = value; }
void update_title();
void initialize_menubar(GUI::MenuBar&);
private:
TextEditorWidget();
@ -91,6 +92,8 @@ private:
RefPtr<GUI::Action> m_markdown_preview_action;
RefPtr<GUI::Action> m_html_preview_action;
RefPtr<GUI::ToolBar> m_toolbar;
RefPtr<GUI::ToolBarContainer> m_toolbar_container;
RefPtr<GUI::StatusBar> m_statusbar;
RefPtr<GUI::TextBox> m_find_textbox;