RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:17:35 +00:00
Code Issues Activity Actions

WindowServer: Redraw menu items after client updates them somehow

Browse source 
This fixes an issue where the undo/redo actions in TextEditor only
updated once you hovered over them.
This commit is contained in:
Andreas Kling 2022-08-21 20:04:33 +02:00
parent 42435ce5e4
commit 17687435ca
2 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Services/WindowServer/ConnectionFromClient.cpp
View file

@ -191,6 +191,8 @@ void ConnectionFromClient::update_menu_item(i32 menu_id, i32 identifier, [[maybe
menu_item->set_default(is_default); menu_item->set_default(is_default);
if (checkable) if (checkable)
menu_item->set_checked(checked); menu_item->set_checked(checked);
menu.redraw(*menu_item);
} }
void ConnectionFromClient::remove_menu_item(i32 menu_id, i32 identifier) void ConnectionFromClient::remove_menu_item(i32 menu_id, i32 identifier)

2
Userland/Services/WindowServer/Menu.cpp
View file

@ -106,6 +106,8 @@ void Menu::redraw()
void Menu::redraw(MenuItem const& menu_item) void Menu::redraw(MenuItem const& menu_item)
{ {
if (!menu_window())
return;
draw(menu_item); draw(menu_item);
menu_window()->invalidate(menu_item.rect()); menu_window()->invalidate(menu_item.rect());
} }