RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 16:57:34 +00:00
Code Issues Activity Actions

Revert "LibJS: Remove "uprooting" mechanism from garbage collector"

Browse source 
This reverts commit 6232ad3a0d.

Unfortunately this introduced some flakiness on CI, so it wasn't
quite this simple.
This commit is contained in:
Andreas Kling 2023-07-22 06:53:22 +02:00
parent a2955501d3
commit 1768d70823
6 changed files with 65 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibJS/Tests/builtins/WeakSet/WeakSet.prototype.add.js
View file

@ -16,26 +16,25 @@ test("invalid values", () => {
});
});
function addObjectItem(weakSet) {
weakSet.add({ a: 1 });
}
function addSymbolItem(weakSet) {
weakSet.add(Symbol("foo"));
}
test("automatic removal of garbage-collected values", () => {
const weakSet = new WeakSet();
const objectItem = { a: 1 };
addObjectItem(weakSet);
expect(weakSet.add(objectItem)).toBe(weakSet);
expect(getWeakSetSize(weakSet)).toBe(1);
markAsGarbage("objectItem");
gc();
expect(getWeakSetSize(weakSet)).toBe(0);
addSymbolItem(weakSet);
const symbolItem = Symbol("foo");
expect(weakSet.add(symbolItem)).toBe(weakSet);
expect(getWeakSetSize(weakSet)).toBe(1);
markAsGarbage("symbolItem");
gc();
expect(getWeakSetSize(weakSet)).toBe(0);
});