RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-15 06:54:57 +00:00
Code Issues Activity Actions

LibJS: Fix string roots not being collected

Browse source 
Previously objects were the only heap
allocated value. Now there are also strings.

This replaces a usage of is_object with is_cell.
Without this change strings could be garbage
collected while still being used in an active scope.
This commit is contained in:
Florian Stellbrink 2020-03-12 02:03:48 +01:00 • committed by Andreas Kling
parent 8cf962a102
commit 17705d23fb
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Interpreter.cpp
View file

@ -122,8 +122,8 @@ void Interpreter::collect_roots(Badge<Heap>, HashTable<Cell*>& roots)
for (auto& scope : m_scope_stack) {
for (auto& it : scope.variables) {
if (it.value.is_object())
roots.set(it.value.as_object());
if (it.value.is_cell())
roots.set(it.value.as_cell());
}
}
}