RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:37:36 +00:00
Code Issues Activity Actions

LibWeb: Add SVG <line> element and test case :^)

Browse source
This commit is contained in:
Sam Atkins 2022-02-11 16:56:36 +00:00 • committed by Andreas Kling
parent 3a1a35ef8f
commit 17912330c4
11 changed files with 126 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/SVG/AttributeNames.h
View file

@ -77,8 +77,12 @@ namespace Web::SVG::AttributeNames {
E(viewTarget) \
E(width) \
E(x) \
E(x1) \
E(x2) \
E(xChannelSelector) \
E(y) \
E(y1) \
E(y2) \
E(yChannelSelector) \
E(zoomAndPan)

58
Userland/Libraries/LibWeb/SVG/SVGLineElement.cpp Normal file
View file

@ -0,0 +1,58 @@
/*
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include "SVGLineElement.h"
#include <LibWeb/SVG/AttributeNames.h>
#include <LibWeb/SVG/AttributeParser.h>
namespace Web::SVG {
SVGLineElement::SVGLineElement(DOM::Document& document, QualifiedName qualified_name)
: SVGGeometryElement(document, qualified_name)
{
}
void SVGLineElement::parse_attribute(FlyString const& name, String const& value)
{
SVGGeometryElement::parse_attribute(name, value);
if (name == SVG::AttributeNames::x1) {
m_x1 = AttributeParser::parse_coordinate(value);
m_path.clear();
} else if (name == SVG::AttributeNames::y1) {
m_y1 = AttributeParser::parse_coordinate(value);
m_path.clear();
} else if (name == SVG::AttributeNames::x2) {
m_x2 = AttributeParser::parse_coordinate(value);
m_path.clear();
} else if (name == SVG::AttributeNames::y2) {
m_y2 = AttributeParser::parse_coordinate(value);
m_path.clear();
}
}
Gfx::Path& SVGLineElement::get_path()
{
if (m_path.has_value())
return m_path.value();
Gfx::Path path;
float x1 = m_x1.value_or(0);
float y1 = m_y1.value_or(0);
float x2 = m_x2.value_or(0);
float y2 = m_y2.value_or(0);
// 1. perform an absolute moveto operation to absolute location (x1,y1)
path.move_to({ x1, y1 });
// 2. perform an absolute lineto operation to absolute location (x2,y2)
path.line_to({ x2, y2 });
m_path = move(path);
return m_path.value();
}
}

33
Userland/Libraries/LibWeb/SVG/SVGLineElement.h Normal file
View file

@ -0,0 +1,33 @@
/*
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <LibWeb/SVG/SVGGeometryElement.h>
namespace Web::SVG {
class SVGLineElement final : public SVGGeometryElement {
public:
using WrapperType = Bindings::SVGLineElementWrapper;
SVGLineElement(DOM::Document&, QualifiedName);
virtual ~SVGLineElement() override = default;
virtual void parse_attribute(FlyString const& name, String const& value) override;
virtual Gfx::Path& get_path() override;
private:
Optional<Gfx::Path> m_path;
Optional<float> m_x1;
Optional<float> m_y1;
Optional<float> m_x2;
Optional<float> m_y2;
};
}

7
Userland/Libraries/LibWeb/SVG/SVGLineElement.idl Normal file
View file

@ -0,0 +1,7 @@
[Exposed=Window]
interface SVGLineElement : SVGGeometryElement {
// [SameObject] readonly attribute SVGAnimatedLength x1;
// [SameObject] readonly attribute SVGAnimatedLength y1;
// [SameObject] readonly attribute SVGAnimatedLength x2;
// [SameObject] readonly attribute SVGAnimatedLength y2;
};

1
Userland/Libraries/LibWeb/SVG/TagNames.h
View file

@ -14,6 +14,7 @@ namespace Web::SVG::TagNames {
__ENUMERATE_SVG_TAG(circle) \
__ENUMERATE_SVG_TAG(ellipse) \
__ENUMERATE_SVG_TAG(g) \
__ENUMERATE_SVG_TAG(line) \
__ENUMERATE_SVG_TAG(path) \
__ENUMERATE_SVG_TAG(rect) \
__ENUMERATE_SVG_TAG(svg)