RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:17:45 +00:00
Code Issues Activity Actions

LibELF: Use StringView literal to avoid string allocations

Browse source
This commit is contained in:
Brian Gianforcaro 2021-07-01 22:29:28 -07:00 • committed by Ali Mohammad Pur
parent 1498dcd9e1
commit 179d8f6815
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibELF/DynamicLinker.cpp
View file

@ -99,7 +99,7 @@ static Result<NonnullRefPtr<DynamicLoader>, DlErrorMessage> map_library(const St
static Result<NonnullRefPtr<DynamicLoader>, DlErrorMessage> map_library(const String& name) static Result<NonnullRefPtr<DynamicLoader>, DlErrorMessage> map_library(const String& name)
{ {
if (name.contains("/")) { if (name.contains("/"sv)) {
int fd = open(name.characters(), O_RDONLY); int fd = open(name.characters(), O_RDONLY);
if (fd < 0) if (fd < 0)
return DlErrorMessage { String::formatted("Could not open shared library: {}", name) }; return DlErrorMessage { String::formatted("Could not open shared library: {}", name) };
@ -300,13 +300,13 @@ static Result<NonnullRefPtr<DynamicLoader>, DlErrorMessage> load_main_library(co
VERIFY(!result.is_error()); VERIFY(!result.is_error());
auto& object = result.value(); auto& object = result.value();
if (loader.filename() == "libsystem.so") { if (loader.filename() == "libsystem.so"sv) {
if (syscall(SC_msyscall, object->base_address().as_ptr())) { if (syscall(SC_msyscall, object->base_address().as_ptr())) {
VERIFY_NOT_REACHED(); VERIFY_NOT_REACHED();
} }
} }
if (loader.filename() == "libc.so") { if (loader.filename() == "libc.so"sv) {
initialize_libc(*object); initialize_libc(*object);
} }
} }
@ -480,7 +480,7 @@ static Result<void, DlErrorMessage> __dladdr(void* addr, Dl_info* info)
static void read_environment_variables() static void read_environment_variables()
{ {
for (char** env = s_envp; *env; ++env) { for (char** env = s_envp; *env; ++env) {
if (StringView { *env } == "_LOADER_BREAKPOINT=1") { if (StringView { *env } == "_LOADER_BREAKPOINT=1"sv) {
s_do_breakpoint_trap_before_entry = true; s_do_breakpoint_trap_before_entry = true;
} }
} }