RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:38:12 +00:00
Code Issues Activity Actions

LibGUI: Don't update cursor, if visual data out-of-date

Browse source 
This fixes https://github.com/SerenityOS/serenity/issues/2498
A nullptr dereference was caused by the visual data beeing out of sync
with the line data, due to a deferred recompute.
This commit is contained in:
Kevin Meyer 2020-06-13 00:31:46 +02:00 • committed by Andreas Kling
parent e0f4fdc9b4
commit 17aa917073
2 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibGUI/TextEditor.h
View file

@ -259,7 +259,9 @@ private:
NonnullRefPtrVector<Action> m_custom_context_menu_actions;
size_t m_reflow_deferred { 0 };
size_t m_reflow_requested { 0 };
bool m_reflow_requested { false };
bool is_visual_data_up_to_date() const { return !m_reflow_requested; }
RefPtr<TextDocument> m_document;