From 17b66eaa3c54a7daede6a11181d301faed77a6f3 Mon Sep 17 00:00:00 2001 From: Daniel Bertalan Date: Thu, 21 Oct 2021 20:02:57 +0200 Subject: [PATCH] Kernel: Call try_set_coredump_property with StringView arguments Storing assigning a string literal to a String object just to pass it to a function expecting a StringView is wasteful. Let's just not do that. For consistency's sake, this commit changes all of the other invocations to use StringView literals, too. --- Kernel/Arch/x86/common/Interrupts.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Kernel/Arch/x86/common/Interrupts.cpp b/Kernel/Arch/x86/common/Interrupts.cpp index 879c65476b..d5ddc1d2a6 100644 --- a/Kernel/Arch/x86/common/Interrupts.cpp +++ b/Kernel/Arch/x86/common/Interrupts.cpp @@ -403,14 +403,14 @@ void page_fault_handler(TrapFrame* trap) if (current_thread) { auto& current_process = current_thread->process(); if (current_process.is_user_process()) { - (void)current_process.try_set_coredump_property("fault_address", String::formatted("{:p}", fault_address)); - (void)current_process.try_set_coredump_property("fault_type", fault.type() == PageFault::Type::PageNotPresent ? "NotPresent" : "ProtectionViolation"); - String fault_access; + (void)current_process.try_set_coredump_property("fault_address"sv, String::formatted("{:p}", fault_address)); + (void)current_process.try_set_coredump_property("fault_type"sv, fault.type() == PageFault::Type::PageNotPresent ? "NotPresent"sv : "ProtectionViolation"sv); + StringView fault_access; if (fault.is_instruction_fetch()) - fault_access = "Execute"; + fault_access = "Execute"sv; else - fault_access = fault.access() == PageFault::Access::Read ? "Read" : "Write"; - (void)current_process.try_set_coredump_property("fault_access", fault_access); + fault_access = fault.access() == PageFault::Access::Read ? "Read"sv : "Write"sv; + (void)current_process.try_set_coredump_property("fault_access"sv, fault_access); } }