RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:57:35 +00:00
Code Issues Activity Actions

LibWeb: Hoist an early return in Layout::BlockBox::paint()

Browse source
This commit is contained in:
Andreas Kling 2020-12-03 17:17:11 +01:00
parent 194d7d3471
commit 17e9a5e0c5
1 changed files with 18 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibWeb/Layout/BlockBox.cpp
View file

@ -54,9 +54,11 @@ void BlockBox::paint(PaintContext& context, PaintPhase phase)
Box::paint(context, phase); Box::paint(context, phase);
if (!children_are_inline())
return;
// FIXME: Inline backgrounds etc. // FIXME: Inline backgrounds etc.
if (phase == PaintPhase::Foreground) { if (phase == PaintPhase::Foreground) {
if (children_are_inline()) {
for (auto& line_box : m_line_boxes) { for (auto& line_box : m_line_boxes) {
for (auto& fragment : line_box.fragments()) { for (auto& fragment : line_box.fragments()) {
if (context.should_show_line_box_borders()) if (context.should_show_line_box_borders())
@ -65,10 +67,8 @@ void BlockBox::paint(PaintContext& context, PaintPhase phase)
} }
} }
} }
}
if (phase == PaintPhase::FocusOutline) { if (phase == PaintPhase::FocusOutline) {
if (children_are_inline()) {
for (auto& line_box : m_line_boxes) { for (auto& line_box : m_line_boxes) {
for (auto& fragment : line_box.fragments()) { for (auto& fragment : line_box.fragments()) {
auto* node = fragment.layout_node().dom_node(); auto* node = fragment.layout_node().dom_node();
@ -82,7 +82,6 @@ void BlockBox::paint(PaintContext& context, PaintPhase phase)
} }
} }
} }
}
} }
HitTestResult BlockBox::hit_test(const Gfx::IntPoint& position, HitTestType type) const HitTestResult BlockBox::hit_test(const Gfx::IntPoint& position, HitTestType type) const