From 1856400547d004f2de201c332f30754b3d8f91f3 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Sun, 11 Jul 2021 21:58:14 +0100 Subject: [PATCH] LibJS: Uncomment Object.{freeze,seal}() tests that now pass :^) --- .../Libraries/LibJS/Tests/builtins/Object/Object.freeze.js | 5 ++--- .../Libraries/LibJS/Tests/builtins/Object/Object.seal.js | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/Userland/Libraries/LibJS/Tests/builtins/Object/Object.freeze.js b/Userland/Libraries/LibJS/Tests/builtins/Object/Object.freeze.js index f8b7a89f69..39d5720055 100644 --- a/Userland/Libraries/LibJS/Tests/builtins/Object/Object.freeze.js +++ b/Userland/Libraries/LibJS/Tests/builtins/Object/Object.freeze.js @@ -29,9 +29,8 @@ describe("normal behavior", () => { test("prevents changing attributes of existing properties", () => { const o = { foo: "bar" }; Object.freeze(o); - // FIXME: These don't change anything and should not throw! - // expect(Object.defineProperty(o, "foo", {})).toBe(o); - // expect(Object.defineProperty(o, "foo", { configurable: false })).toBe(o); + expect(Object.defineProperty(o, "foo", {})).toBe(o); + expect(Object.defineProperty(o, "foo", { configurable: false })).toBe(o); expect(() => { Object.defineProperty(o, "foo", { configurable: true }); }).toThrowWithMessage(TypeError, "Object's [[DefineOwnProperty]] method returned false"); diff --git a/Userland/Libraries/LibJS/Tests/builtins/Object/Object.seal.js b/Userland/Libraries/LibJS/Tests/builtins/Object/Object.seal.js index d48b0bd9f6..20d6239d82 100644 --- a/Userland/Libraries/LibJS/Tests/builtins/Object/Object.seal.js +++ b/Userland/Libraries/LibJS/Tests/builtins/Object/Object.seal.js @@ -29,9 +29,8 @@ describe("normal behavior", () => { test("prevents changing attributes of existing properties", () => { const o = { foo: "bar" }; Object.seal(o); - // FIXME: These don't change anything and should not throw! - // expect(Object.defineProperty(o, "foo", {})).toBe(o); - // expect(Object.defineProperty(o, "foo", { configurable: false })).toBe(o); + expect(Object.defineProperty(o, "foo", {})).toBe(o); + expect(Object.defineProperty(o, "foo", { configurable: false })).toBe(o); expect(() => { Object.defineProperty(o, "foo", { configurable: true }); }).toThrowWithMessage(TypeError, "Object's [[DefineOwnProperty]] method returned false");