RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:07:46 +00:00
Code Issues Activity Actions

TelnetServer: Use AK::Stream to serialize commands

Browse source
This commit is contained in:
Tim Schumacher 2023-02-07 15:01:39 +01:00 • committed by Linus Groh
parent 43f36d5e7f
commit 185787d29d
1 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Services/TelnetServer/Client.cpp
View file

@ -7,8 +7,8 @@
#include "Client.h" #include "Client.h"
#include <AK/ByteBuffer.h> #include <AK/ByteBuffer.h>
#include <AK/DeprecatedMemoryStream.h>
#include <AK/DeprecatedString.h> #include <AK/DeprecatedString.h>
#include <AK/MemoryStream.h>
#include <AK/StringBuilder.h> #include <AK/StringBuilder.h>
#include <AK/StringView.h> #include <AK/StringView.h>
#include <AK/Types.h> #include <AK/Types.h>
@ -194,12 +194,15 @@ ErrorOr<void> Client::send_command(Command command)
ErrorOr<void> Client::send_commands(Vector<Command> commands) ErrorOr<void> Client::send_commands(Vector<Command> commands)
{ {
auto buffer = TRY(ByteBuffer::create_uninitialized(commands.size() * 3)); auto buffer = TRY(ByteBuffer::create_uninitialized(commands.size() * 3));
DeprecatedOutputMemoryStream stream { buffer }; FixedMemoryStream stream { buffer.span() };
for (auto& command : commands) for (auto& command : commands) {
stream << (u8)IAC << command.command << command.subcommand; MUST(stream.write_value<u8>(IAC));
MUST(stream.write_value(command.command));
MUST(stream.write_value(command.subcommand));
}
VERIFY(stream.is_end()); VERIFY(TRY(stream.tell()) == buffer.size());
TRY(m_socket->write({ buffer.data(), buffer.size() })); TRY(m_socket->write({ buffer.data(), buffer.size() }));
return {}; return {};
} }