RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:07:44 +00:00
Code Issues Activity Actions

LibWeb: Port CSSNamespaceRule to FlyString

Browse source 
This removes a performance problem where we'd convert the style sheet's
default namespace from DeprecatedFlyString to FlyString once per rule
during selector matching.

The conversion now happens once, during CSS parse. It should eventually
be removed from there as well, but one step at a time. :^)
This commit is contained in:
Andreas Kling 2023-12-01 13:36:40 +01:00
parent d8f84ef76c
commit 189d1e8291
4 changed files with 21 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -1358,18 +1358,18 @@ CSSRule* Parser::convert_to_rule(NonnullRefPtr<Rule> rule)
token_stream.skip_whitespace();
auto token = token_stream.next_token();
Optional<DeprecatedString> prefix = {};
Optional<FlyString> prefix = {};
if (token.is(Token::Type::Ident)) {
prefix = token.token().ident().bytes_as_string_view();
prefix = token.token().ident();
token_stream.skip_whitespace();
token = token_stream.next_token();
}
DeprecatedString namespace_uri;
FlyString namespace_uri;
if (token.is(Token::Type::String)) {
namespace_uri = token.token().string();
namespace_uri = MUST(FlyString::from_utf8(token.token().string()));
} else if (auto url = parse_url_function(token); url.has_value()) {
namespace_uri = url.value().to_deprecated_string();
namespace_uri = MUST(FlyString::from_deprecated_fly_string(url.value().to_deprecated_string()));
} else {
dbgln_if(CSS_PARSER_DEBUG, "CSSParser: @namespace rule invalid; discarding.");
return {};