RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:47:44 +00:00
Code Issues Activity Actions

HashFunctions: constexpr capability

Browse source 
Problem:
- Hash functions can be `constexpr`, but are not.

Solution:
- Change `inline` keyword to `constexpr`.
- Add `static_assert` tests to ensure the hash functions work in a
  `constexpr` context.
This commit is contained in:
Lenny Maiorani 2020-10-21 09:39:54 -04:00 • committed by Andreas Kling
parent 070fc69562
commit 18a40587ea
2 changed files with 26 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

26
AK/Tests/TestHashFunctions.cpp
View file

@ -31,30 +31,32 @@
TEST_CASE(int_hash)
{
EXPECT_EQ(int_hash(42), 3564735745u);
EXPECT_EQ(int_hash(0), 1177991625u);
static_assert(int_hash(42) == 3564735745u);
static_assert(int_hash(0) == 1177991625u);
}
TEST_CASE(double_hash)
{
EXPECT_EQ(double_hash(42), 524450u);
EXPECT_EQ(double_hash(0), 12384u);
static_assert(double_hash(42) == 524450u);
static_assert(double_hash(0) == 12384u);
}
TEST_CASE(pair_int_hash)
{
EXPECT_EQ(pair_int_hash(42, 17), 339337046u);
EXPECT_EQ(pair_int_hash(0, 0), 954888656u);
static_assert(pair_int_hash(42, 17) == 339337046u);
static_assert(pair_int_hash(0, 0) == 954888656u);
}
TEST_CASE(u64_hash)
{
EXPECT_EQ(u64_hash(42), 2824066580u);
EXPECT_EQ(u64_hash(0), 954888656u);
static_assert(u64_hash(42) == 2824066580u);
static_assert(u64_hash(0) == 954888656u);
}
TEST_CASE(ptr_hash)
{
// These tests are not static_asserts because the values are
// different and the goal is to bind the behavior.
if constexpr (sizeof(FlatPtr) == 8) {
EXPECT_EQ(ptr_hash(FlatPtr(42)), 2824066580u);
EXPECT_EQ(ptr_hash(FlatPtr(0)), 954888656u);
@ -70,4 +72,12 @@ TEST_CASE(ptr_hash)
}
}
TEST_CASE(constexpr_ptr_hash)
{
// This test does not check the result because the goal is just to
// ensure the function can be executed in a constexpr context. The
// "ptr_hash" test binds the result.
static_assert(ptr_hash(FlatPtr(42)));
}
TEST_MAIN(HashFunctions)