From 18aeda2e0d89d66aa2833f374d142203b1687c0f Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 3 Aug 2019 19:20:05 +0200 Subject: [PATCH] BufferStream: It's not an error to read up to the very end of a buffer Don't signal an error before we've reached the very end of the buffer. --- AK/BufferStream.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/AK/BufferStream.h b/AK/BufferStream.h index 8a255a39bc..a1809f6d03 100644 --- a/AK/BufferStream.h +++ b/AK/BufferStream.h @@ -24,7 +24,7 @@ public: } BufferStream& operator>>(i8& value) { - if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) { + if (m_offset + sizeof(value) > unsigned(m_buffer.size())) { m_read_failure = true; return *this; } @@ -39,7 +39,7 @@ public: } BufferStream& operator>>(u8& value ) { - if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) { + if (m_offset + sizeof(value) > unsigned(m_buffer.size())) { m_read_failure = true; return *this; } @@ -54,7 +54,7 @@ public: } BufferStream& operator>>(bool& value ) { - if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) { + if (m_offset + sizeof(value) > unsigned(m_buffer.size())) { m_read_failure = true; return *this; } @@ -69,7 +69,7 @@ public: } BufferStream& operator>>(char& value) { - if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) { + if (m_offset + sizeof(value) > unsigned(m_buffer.size())) { m_read_failure = true; return *this; } @@ -85,7 +85,7 @@ public: } BufferStream& operator>>(u16& value) { - if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) { + if (m_offset + sizeof(value) > unsigned(m_buffer.size())) { m_read_failure = true; return *this; } @@ -105,7 +105,7 @@ public: } BufferStream& operator>>(i16& value) { - if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) { + if (m_offset + sizeof(value) > unsigned(m_buffer.size())) { m_read_failure = true; return *this; } @@ -127,7 +127,7 @@ public: } BufferStream& operator>>(u32& value) { - if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) { + if (m_offset + sizeof(value) > unsigned(m_buffer.size())) { m_read_failure = true; return *this; } @@ -153,7 +153,7 @@ public: } BufferStream& operator>>(i32& value) { - if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) { + if (m_offset + sizeof(value) > unsigned(m_buffer.size())) { m_read_failure = true; return *this; }