RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:27:34 +00:00
Code Issues Activity Actions

LibJS: Make Cell::initialize() return void

Browse source 
Stop worrying about tiny OOMs.

Work towards #20405
This commit is contained in:
Andreas Kling 2023-08-07 08:41:28 +02:00
parent fde26c53f0
commit 18c54d8d40
804 changed files with 1330 additions and 2171 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/CSS/CSSConditionRule.cpp
View file

@ -28,12 +28,10 @@ void CSSConditionRule::for_each_effective_keyframes_at_rule(Function<void(CSSKey
CSSGroupingRule::for_each_effective_keyframes_at_rule(callback);
}
JS::ThrowCompletionOr<void> CSSConditionRule::initialize(JS::Realm& realm)
void CSSConditionRule::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CSSConditionRulePrototype>(realm, "CSSConditionRule"));
return {};
}
}

2
Userland/Libraries/LibWeb/CSS/CSSConditionRule.h
View file

@ -28,7 +28,7 @@ public:
protected:
CSSConditionRule(JS::Realm&, CSSRuleList&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
};
}

6
Userland/Libraries/LibWeb/CSS/CSSFontFaceRule.cpp
View file

@ -25,12 +25,10 @@ CSSFontFaceRule::CSSFontFaceRule(JS::Realm& realm, FontFace&& font_face)
{
}
JS::ThrowCompletionOr<void> CSSFontFaceRule::initialize(JS::Realm& realm)
void CSSFontFaceRule::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CSSFontFaceRulePrototype>(realm, "CSSFontFaceRule"));
return {};
}
CSSStyleDeclaration* CSSFontFaceRule::style()

2
Userland/Libraries/LibWeb/CSS/CSSFontFaceRule.h
View file

@ -28,7 +28,7 @@ public:
private:
CSSFontFaceRule(JS::Realm&, FontFace&&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual DeprecatedString serialized() const override;
FontFace m_font_face;

6
Userland/Libraries/LibWeb/CSS/CSSGroupingRule.cpp
View file

@ -22,12 +22,10 @@ CSSGroupingRule::CSSGroupingRule(JS::Realm& realm, CSSRuleList& rules)
rule->set_parent_rule(this);
}
JS::ThrowCompletionOr<void> CSSGroupingRule::initialize(JS::Realm& realm)
void CSSGroupingRule::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CSSGroupingRulePrototype>(realm, "CSSGroupingRule"));
return {};
}
void CSSGroupingRule::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/CSS/CSSGroupingRule.h
View file

@ -34,7 +34,7 @@ public:
protected:
CSSGroupingRule(JS::Realm&, CSSRuleList&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
private:

6
Userland/Libraries/LibWeb/CSS/CSSImportRule.cpp
View file

@ -40,12 +40,10 @@ CSSImportRule::CSSImportRule(AK::URL url, DOM::Document& document)
set_resource(ResourceLoader::the().load_resource(Resource::Type::Generic, request));
}
JS::ThrowCompletionOr<void> CSSImportRule::initialize(JS::Realm& realm)
void CSSImportRule::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CSSImportRulePrototype>(realm, "CSSImportRule"));
return {};
}
void CSSImportRule::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/CSS/CSSImportRule.h
View file

@ -40,7 +40,7 @@ public:
private:
CSSImportRule(AK::URL, DOM::Document&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
virtual DeprecatedString serialized() const override;

5
Userland/Libraries/LibWeb/CSS/CSSKeyframeRule.cpp
View file

@ -22,11 +22,10 @@ void CSSKeyframeRule::visit_edges(Visitor& visitor)
visitor.visit(m_declarations);
}
JS::ThrowCompletionOr<void> CSSKeyframeRule::initialize(JS::Realm& realm)
void CSSKeyframeRule::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CSSKeyframeRulePrototype>(realm, "CSSKeyframeRule"));
return {};
}
DeprecatedString CSSKeyframeRule::serialized() const

2
Userland/Libraries/LibWeb/CSS/CSSKeyframeRule.h
View file

@ -48,7 +48,7 @@ private:
}
virtual void visit_edges(Visitor&) override;
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual DeprecatedString serialized() const override;
CSS::Percentage m_key;

6
Userland/Libraries/LibWeb/CSS/CSSKeyframesRule.cpp
View file

@ -22,12 +22,10 @@ void CSSKeyframesRule::visit_edges(Visitor& visitor)
visitor.visit(keyframe);
}
JS::ThrowCompletionOr<void> CSSKeyframesRule::initialize(JS::Realm& realm)
void CSSKeyframesRule::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CSSKeyframesRulePrototype>(realm, "CSSKeyframesRule"));
return {};
}
DeprecatedString CSSKeyframesRule::serialized() const

2
Userland/Libraries/LibWeb/CSS/CSSKeyframesRule.h
View file

@ -46,7 +46,7 @@ private:
virtual void visit_edges(Visitor&) override;
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual DeprecatedString serialized() const override;
FlyString m_name;

6
Userland/Libraries/LibWeb/CSS/CSSMediaRule.cpp
View file

@ -23,12 +23,10 @@ CSSMediaRule::CSSMediaRule(JS::Realm& realm, MediaList& media, CSSRuleList& rule
{
}
JS::ThrowCompletionOr<void> CSSMediaRule::initialize(JS::Realm& realm)
void CSSMediaRule::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CSSMediaRulePrototype>(realm, "CSSMediaRule"));
return {};
}
void CSSMediaRule::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/CSS/CSSMediaRule.h
View file

@ -35,7 +35,7 @@ public:
private:
CSSMediaRule(JS::Realm&, MediaList&, CSSRuleList&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
virtual DeprecatedString serialized() const override;

6
Userland/Libraries/LibWeb/CSS/CSSNamespaceRule.cpp
View file

@ -25,12 +25,10 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<CSSNamespaceRule>> CSSNamespaceRule::create
return MUST_OR_THROW_OOM(realm.heap().allocate<CSSNamespaceRule>(realm, realm, prefix, namespace_uri));
}
JS::ThrowCompletionOr<void> CSSNamespaceRule::initialize(JS::Realm& realm)
void CSSNamespaceRule::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CSSNamespaceRulePrototype>(realm, "CSSNamespaceRule"));
return {};
}
// https://www.w3.org/TR/cssom/#serialize-a-css-rule

2
Userland/Libraries/LibWeb/CSS/CSSNamespaceRule.h
View file

@ -27,7 +27,7 @@ public:
private:
CSSNamespaceRule(JS::Realm&, Optional<StringView> prefix, StringView namespace_uri);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual DeprecatedString serialized() const override;
DeprecatedString m_namespace_uri;

6
Userland/Libraries/LibWeb/CSS/CSSRuleList.cpp
View file

@ -36,12 +36,10 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<CSSRuleList>> CSSRuleList::create_empty(JS:
return MUST_OR_THROW_OOM(realm.heap().allocate<CSSRuleList>(realm, realm));
}
JS::ThrowCompletionOr<void> CSSRuleList::initialize(JS::Realm& realm)
void CSSRuleList::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CSSRuleListPrototype>(realm, "CSSRuleList"));
return {};
}
void CSSRuleList::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/CSS/CSSRuleList.h
View file

@ -66,7 +66,7 @@ public:
private:
explicit CSSRuleList(JS::Realm&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
// ^Bindings::LegacyPlatformObject

5
Userland/Libraries/LibWeb/CSS/CSSStyleDeclaration.cpp
View file

@ -20,11 +20,10 @@ CSSStyleDeclaration::CSSStyleDeclaration(JS::Realm& realm)
{
}
JS::ThrowCompletionOr<void> CSSStyleDeclaration::initialize(JS::Realm& realm)
void CSSStyleDeclaration::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CSSStyleDeclarationPrototype>(realm, "CSSStyleDeclaration"));
return {};
}
WebIDL::ExceptionOr<JS::NonnullGCPtr<PropertyOwningCSSStyleDeclaration>> PropertyOwningCSSStyleDeclaration::create(JS::Realm& realm, Vector<StyleProperty> properties, HashMap<DeprecatedString, StyleProperty> custom_properties)

2
Userland/Libraries/LibWeb/CSS/CSSStyleDeclaration.h
View file

@ -19,7 +19,7 @@ class CSSStyleDeclaration : public Bindings::PlatformObject {
public:
virtual ~CSSStyleDeclaration() = default;
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual size_t length() const = 0;
virtual DeprecatedString item(size_t index) const = 0;

6
Userland/Libraries/LibWeb/CSS/CSSStyleRule.cpp
View file

@ -24,12 +24,10 @@ CSSStyleRule::CSSStyleRule(JS::Realm& realm, Vector<NonnullRefPtr<Selector>>&& s
{
}
JS::ThrowCompletionOr<void> CSSStyleRule::initialize(JS::Realm& realm)
void CSSStyleRule::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CSSStyleRulePrototype>(realm, "CSSStyleRule"));
return {};
}
void CSSStyleRule::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/CSS/CSSStyleRule.h
View file

@ -35,7 +35,7 @@ public:
private:
CSSStyleRule(JS::Realm&, Vector<NonnullRefPtr<Selector>>&&, CSSStyleDeclaration&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
virtual DeprecatedString serialized() const override;

6
Userland/Libraries/LibWeb/CSS/CSSStyleSheet.cpp
View file

@ -37,12 +37,10 @@ CSSStyleSheet::CSSStyleSheet(JS::Realm& realm, CSSRuleList& rules, MediaList& me
};
}
JS::ThrowCompletionOr<void> CSSStyleSheet::initialize(JS::Realm& realm)
void CSSStyleSheet::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CSSStyleSheetPrototype>(realm, "CSSStyleSheet"));
return {};
}
void CSSStyleSheet::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/CSS/CSSStyleSheet.h
View file

@ -54,7 +54,7 @@ public:
private:
CSSStyleSheet(JS::Realm&, CSSRuleList&, MediaList&, Optional<AK::URL> location);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
void recalculate_namespaces();

6
Userland/Libraries/LibWeb/CSS/CSSSupportsRule.cpp
View file

@ -22,12 +22,10 @@ CSSSupportsRule::CSSSupportsRule(JS::Realm& realm, NonnullRefPtr<Supports>&& sup
{
}
JS::ThrowCompletionOr<void> CSSSupportsRule::initialize(JS::Realm& realm)
void CSSSupportsRule::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CSSSupportsRulePrototype>(realm, "CSSSupportsRule"));
return {};
}
DeprecatedString CSSSupportsRule::condition_text() const

2
Userland/Libraries/LibWeb/CSS/CSSSupportsRule.h
View file

@ -32,7 +32,7 @@ public:
private:
CSSSupportsRule(JS::Realm&, NonnullRefPtr<Supports>&&, CSSRuleList&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual DeprecatedString serialized() const override;
NonnullRefPtr<Supports> m_supports;

6
Userland/Libraries/LibWeb/CSS/MediaList.cpp
View file

@ -24,12 +24,10 @@ MediaList::MediaList(JS::Realm& realm, Vector<NonnullRefPtr<MediaQuery>>&& media
{
}
JS::ThrowCompletionOr<void> MediaList::initialize(JS::Realm& realm)
void MediaList::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::MediaListPrototype>(realm, "MediaList"));
return {};
}
// https://www.w3.org/TR/cssom-1/#dom-medialist-mediatext

2
Userland/Libraries/LibWeb/CSS/MediaList.h
View file

@ -39,7 +39,7 @@ public:
private:
MediaList(JS::Realm&, Vector<NonnullRefPtr<MediaQuery>>&&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
// ^Bindings::LegacyPlatformObject
virtual bool supports_indexed_properties() const override { return true; }

6
Userland/Libraries/LibWeb/CSS/MediaQueryList.cpp
View file

@ -28,12 +28,10 @@ MediaQueryList::MediaQueryList(DOM::Document& document, Vector<NonnullRefPtr<Med
evaluate();
}
JS::ThrowCompletionOr<void> MediaQueryList::initialize(JS::Realm& realm)
void MediaQueryList::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::MediaQueryListPrototype>(realm, "MediaQueryList"));
return {};
}
void MediaQueryList::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/CSS/MediaQueryList.h
View file

@ -34,7 +34,7 @@ public:
private:
MediaQueryList(DOM::Document&, Vector<NonnullRefPtr<MediaQuery>>&&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
JS::NonnullGCPtr<DOM::Document> m_document;

6
Userland/Libraries/LibWeb/CSS/MediaQueryListEvent.cpp
View file

@ -24,12 +24,10 @@ MediaQueryListEvent::MediaQueryListEvent(JS::Realm& realm, FlyString const& even
MediaQueryListEvent::~MediaQueryListEvent() = default;
JS::ThrowCompletionOr<void> MediaQueryListEvent::initialize(JS::Realm& realm)
void MediaQueryListEvent::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::MediaQueryListEventPrototype>(realm, "MediaQueryListEvent"));
return {};
}
}

2
Userland/Libraries/LibWeb/CSS/MediaQueryListEvent.h
View file

@ -30,7 +30,7 @@ public:
private:
MediaQueryListEvent(JS::Realm&, FlyString const& event_name, MediaQueryListEventInit const& event_init);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
String m_media;
bool m_matches;

6
Userland/Libraries/LibWeb/CSS/Screen.cpp
View file

@ -24,12 +24,10 @@ Screen::Screen(HTML::Window& window)
{
}
JS::ThrowCompletionOr<void> Screen::initialize(JS::Realm& realm)
void Screen::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::ScreenPrototype>(realm, "Screen"));
return {};
}
void Screen::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/CSS/Screen.h
View file

@ -29,7 +29,7 @@ public:
private:
explicit Screen(HTML::Window&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
HTML::Window const& window() const { return *m_window; }

6
Userland/Libraries/LibWeb/CSS/StyleSheetList.cpp
View file

@ -74,12 +74,10 @@ StyleSheetList::StyleSheetList(DOM::Document& document)
{
}
JS::ThrowCompletionOr<void> StyleSheetList::initialize(JS::Realm& realm)
void StyleSheetList::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::StyleSheetListPrototype>(realm, "StyleSheetList"));
return {};
}
void StyleSheetList::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/CSS/StyleSheetList.h
View file

@ -42,7 +42,7 @@ public:
private:
explicit StyleSheetList(DOM::Document&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
// ^Bindings::LegacyPlatformObject

6
Userland/Libraries/LibWeb/CSS/VisualViewport.cpp
View file

@ -26,12 +26,10 @@ VisualViewport::VisualViewport(DOM::Document& document)
{
}
JS::ThrowCompletionOr<void> VisualViewport::initialize(JS::Realm& realm)
void VisualViewport::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::VisualViewportPrototype>(realm, "VisualViewport"));
return {};
}
void VisualViewport::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/CSS/VisualViewport.h
View file

@ -40,7 +40,7 @@ public:
private:
explicit VisualViewport(DOM::Document&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
JS::NonnullGCPtr<DOM::Document> m_document;