RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 01:27:34 +00:00
Code Issues Activity Actions

LibJS: Make Cell::initialize() return void

Browse source 
Stop worrying about tiny OOMs.

Work towards #20405
This commit is contained in:
Andreas Kling 2023-08-07 08:41:28 +02:00
parent fde26c53f0
commit 18c54d8d40
804 changed files with 1330 additions and 2171 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/Crypto/Crypto.cpp
View file

@ -27,15 +27,11 @@ Crypto::Crypto(JS::Realm& realm)
Crypto::~Crypto() = default;
JS::ThrowCompletionOr<void> Crypto::initialize(JS::Realm& realm)
void Crypto::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CryptoPrototype>(realm, "Crypto"));
m_subtle = TRY(Bindings::throw_dom_exception_if_needed(realm.vm(), [&]() {
return SubtleCrypto::create(realm);
}));
return {};
m_subtle = MUST(SubtleCrypto::create(realm));
}
JS::NonnullGCPtr<SubtleCrypto> Crypto::subtle() const

2
Userland/Libraries/LibWeb/Crypto/Crypto.h
View file

@ -26,7 +26,7 @@ public:
WebIDL::ExceptionOr<String> random_uuid() const;
protected:
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
private:

6
Userland/Libraries/LibWeb/Crypto/SubtleCrypto.cpp
View file

@ -26,12 +26,10 @@ SubtleCrypto::SubtleCrypto(JS::Realm& realm)
SubtleCrypto::~SubtleCrypto() = default;
JS::ThrowCompletionOr<void> SubtleCrypto::initialize(JS::Realm& realm)
void SubtleCrypto::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::SubtleCryptoPrototype>(realm, "SubtleCrypto"));
return {};
}
// https://w3c.github.io/webcrypto/#dfn-SubtleCrypto-method-digest

2
Userland/Libraries/LibWeb/Crypto/SubtleCrypto.h
View file

@ -23,7 +23,7 @@ public:
private:
explicit SubtleCrypto(JS::Realm&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
};
}