1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 14:37:45 +00:00

LibJS: Make Cell::initialize() return void

Stop worrying about tiny OOMs.

Work towards #20405
This commit is contained in:
Andreas Kling 2023-08-07 08:41:28 +02:00
parent fde26c53f0
commit 18c54d8d40
804 changed files with 1330 additions and 2171 deletions

View file

@ -25,12 +25,10 @@ AbortController::AbortController(JS::Realm& realm, JS::NonnullGCPtr<AbortSignal>
AbortController::~AbortController() = default;
JS::ThrowCompletionOr<void> AbortController::initialize(JS::Realm& realm)
void AbortController::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::AbortControllerPrototype>(realm, "AbortController"));
return {};
}
void AbortController::visit_edges(Cell::Visitor& visitor)

View file

@ -28,7 +28,7 @@ public:
private:
AbortController(JS::Realm&, JS::NonnullGCPtr<AbortSignal>);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
// https://dom.spec.whatwg.org/#abortcontroller-signal

View file

@ -22,12 +22,10 @@ AbortSignal::AbortSignal(JS::Realm& realm)
{
}
JS::ThrowCompletionOr<void> AbortSignal::initialize(JS::Realm& realm)
void AbortSignal::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::AbortSignalPrototype>(realm, "AbortSignal"));
return {};
}
// https://dom.spec.whatwg.org/#abortsignal-add

View file

@ -43,7 +43,7 @@ public:
private:
explicit AbortSignal(JS::Realm&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(JS::Cell::Visitor&) override;
// https://dom.spec.whatwg.org/#abortsignal-abort-reason

View file

@ -21,12 +21,10 @@ AbstractRange::AbstractRange(Node& start_container, u32 start_offset, Node& end_
AbstractRange::~AbstractRange() = default;
JS::ThrowCompletionOr<void> AbstractRange::initialize(JS::Realm& realm)
void AbstractRange::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::AbstractRangePrototype>(realm, "AbstractRange"));
return {};
}
void AbstractRange::visit_edges(Cell::Visitor& visitor)

View file

@ -36,7 +36,7 @@ public:
protected:
AbstractRange(Node& start_container, u32 start_offset, Node& end_container, u32 end_offset);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
JS::NonnullGCPtr<Node> m_start_container;

View file

@ -38,12 +38,10 @@ Attr::Attr(Document& document, QualifiedName qualified_name, DeprecatedString va
{
}
JS::ThrowCompletionOr<void> Attr::initialize(JS::Realm& realm)
void Attr::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::AttrPrototype>(realm, "Attr"));
return {};
}
void Attr::visit_edges(Cell::Visitor& visitor)

View file

@ -46,7 +46,7 @@ public:
private:
Attr(Document&, QualifiedName, DeprecatedString value, Element*);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
QualifiedName m_qualified_name;

View file

@ -16,12 +16,10 @@ CDATASection::CDATASection(Document& document, DeprecatedString const& data)
CDATASection::~CDATASection() = default;
JS::ThrowCompletionOr<void> CDATASection::initialize(JS::Realm& realm)
void CDATASection::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CDATASectionPrototype>(realm, "CDATASection"));
return {};
}
}

View file

@ -23,7 +23,7 @@ public:
private:
CDATASection(Document&, DeprecatedString const&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
};
template<>

View file

@ -19,12 +19,10 @@ CharacterData::CharacterData(Document& document, NodeType type, DeprecatedString
{
}
JS::ThrowCompletionOr<void> CharacterData::initialize(JS::Realm& realm)
void CharacterData::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CharacterDataPrototype>(realm, "CharacterData"));
return {};
}
// https://dom.spec.whatwg.org/#dom-characterdata-data

View file

@ -36,7 +36,7 @@ public:
protected:
CharacterData(Document&, NodeType, DeprecatedString const&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
private:
DeprecatedString m_data;

View file

@ -23,12 +23,10 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<Comment>> Comment::construct_impl(JS::Realm
return MUST_OR_THROW_OOM(realm.heap().allocate<Comment>(realm, window.associated_document(), data));
}
JS::ThrowCompletionOr<void> Comment::initialize(JS::Realm& realm)
void Comment::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CommentPrototype>(realm, "Comment"));
return {};
}
}

View file

@ -23,7 +23,7 @@ public:
private:
Comment(Document&, DeprecatedString const&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
};
template<>

View file

@ -29,12 +29,10 @@ CustomEvent::CustomEvent(JS::Realm& realm, FlyString const& event_name, CustomEv
CustomEvent::~CustomEvent() = default;
JS::ThrowCompletionOr<void> CustomEvent::initialize(JS::Realm& realm)
void CustomEvent::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::CustomEventPrototype>(realm, "CustomEvent"));
return {};
}
void CustomEvent::visit_edges(JS::Cell::Visitor& visitor)

View file

@ -29,7 +29,7 @@ public:
// https://dom.spec.whatwg.org/#dom-customevent-detail
JS::Value detail() const { return m_detail; }
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(JS::Cell::Visitor&) override;
void init_custom_event(String const& type, bool bubbles, bool cancelable, JS::Value detail);

View file

@ -31,12 +31,10 @@ DOMImplementation::DOMImplementation(Document& document)
DOMImplementation::~DOMImplementation() = default;
JS::ThrowCompletionOr<void> DOMImplementation::initialize(JS::Realm& realm)
void DOMImplementation::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DOMImplementationPrototype>(realm, "DOMImplementation"));
return {};
}
void DOMImplementation::visit_edges(Cell::Visitor& visitor)

View file

@ -30,7 +30,7 @@ public:
private:
explicit DOMImplementation(Document&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
Document& document() { return m_document; }

View file

@ -68,12 +68,10 @@ DOMTokenList::DOMTokenList(Element& associated_element, DeprecatedFlyString asso
associated_attribute_changed(value);
}
JS::ThrowCompletionOr<void> DOMTokenList::initialize(JS::Realm& realm)
void DOMTokenList::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DOMTokenListPrototype>(realm, "DOMTokenList"));
return {};
}
void DOMTokenList::visit_edges(Cell::Visitor& visitor)

View file

@ -46,7 +46,7 @@ public:
private:
DOMTokenList(Element& associated_element, DeprecatedFlyString associated_attribute);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
// ^Bindings::LegacyPlatformObject

View file

@ -336,16 +336,14 @@ Document::~Document()
HTML::main_thread_event_loop().unregister_document({}, *this);
}
JS::ThrowCompletionOr<void> Document::initialize(JS::Realm& realm)
void Document::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DocumentPrototype>(realm, "Document"));
m_selection = MUST_OR_THROW_OOM(heap().allocate<Selection::Selection>(realm, realm, *this));
m_selection = MUST(heap().allocate<Selection::Selection>(realm, realm, *this));
m_list_of_available_images = TRY_OR_THROW_OOM(realm.vm(), try_make<HTML::ListOfAvailableImages>());
return {};
m_list_of_available_images = make<HTML::ListOfAvailableImages>();
}
void Document::visit_edges(Cell::Visitor& visitor)

View file

@ -500,7 +500,7 @@ public:
void shared_declarative_refresh_steps(StringView input, JS::GCPtr<HTML::HTMLMetaElement const> meta_element = nullptr);
protected:
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
Document(JS::Realm&, AK::URL const&);

View file

@ -14,12 +14,10 @@ DocumentFragment::DocumentFragment(Document& document)
{
}
JS::ThrowCompletionOr<void> DocumentFragment::initialize(JS::Realm& realm)
void DocumentFragment::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DocumentFragmentPrototype>(realm, "DocumentFragment"));
return {};
}
void DocumentFragment::visit_edges(Cell::Visitor& visitor)

View file

@ -33,7 +33,7 @@ public:
protected:
explicit DocumentFragment(Document& document);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
private:

View file

@ -19,12 +19,10 @@ DocumentType::DocumentType(Document& document)
{
}
JS::ThrowCompletionOr<void> DocumentType::initialize(JS::Realm& realm)
void DocumentType::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DocumentTypePrototype>(realm, "DocumentType"));
return {};
}
}

View file

@ -36,7 +36,7 @@ public:
private:
explicit DocumentType(Document&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
DeprecatedString m_name;
DeprecatedString m_public_id;

View file

@ -70,16 +70,12 @@ Element::Element(Document& document, DOM::QualifiedName qualified_name)
Element::~Element() = default;
JS::ThrowCompletionOr<void> Element::initialize(JS::Realm& realm)
void Element::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::ElementPrototype>(realm, "Element"));
m_attributes = TRY(Bindings::throw_dom_exception_if_needed(realm.vm(), [&]() {
return NamedNodeMap::create(*this);
}));
return {};
m_attributes = MUST(NamedNodeMap::create(*this));
}
void Element::visit_edges(Cell::Visitor& visitor)

View file

@ -324,7 +324,7 @@ public:
protected:
Element(Document&, DOM::QualifiedName);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void children_changed() override;
virtual i32 default_tab_index_value() const;

View file

@ -41,12 +41,10 @@ Event::Event(JS::Realm& realm, FlyString const& type, EventInit const& event_ini
{
}
JS::ThrowCompletionOr<void> Event::initialize(JS::Realm& realm)
void Event::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::EventPrototype>(realm, "Event"));
return {};
}
void Event::visit_edges(Visitor& visitor)

View file

@ -146,7 +146,7 @@ public:
protected:
void initialize_event(String const&, bool, bool);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Visitor&) override;
private:

View file

@ -52,16 +52,14 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<EventTarget>> EventTarget::construct_impl(J
return MUST_OR_THROW_OOM(realm.heap().allocate<EventTarget>(realm, realm));
}
JS::ThrowCompletionOr<void> EventTarget::initialize(JS::Realm& realm)
void EventTarget::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
// FIXME: We can't do this for HTML::Window currently, as this will run when creating the initial global object.
// During this time, the ESO is not setup, so it will cause a nullptr dereference in host_defined_intrinsics.
if (!is<HTML::Window>(this))
set_prototype(&Bindings::ensure_web_prototype<Bindings::EventTargetPrototype>(realm, "EventTarget"));
return {};
}
void EventTarget::visit_edges(Cell::Visitor& visitor)

View file

@ -64,7 +64,7 @@ protected:
void element_event_handler_attribute_changed(FlyString const& local_name, Optional<String> const& value);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
private:

View file

@ -28,12 +28,10 @@ HTMLCollection::HTMLCollection(ParentNode& root, Scope scope, Function<bool(Elem
HTMLCollection::~HTMLCollection() = default;
JS::ThrowCompletionOr<void> HTMLCollection::initialize(JS::Realm& realm)
void HTMLCollection::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::HTMLCollectionPrototype>(realm, "HTMLCollection"));
return {};
}
void HTMLCollection::visit_edges(Cell::Visitor& visitor)

View file

@ -52,7 +52,7 @@ public:
protected:
HTMLCollection(ParentNode& root, Scope, Function<bool(Element const&)> filter);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
JS::NonnullGCPtr<ParentNode> root() { return *m_root; }

View file

@ -31,12 +31,10 @@ MutationObserver::MutationObserver(JS::Realm& realm, JS::GCPtr<WebIDL::CallbackT
MutationObserver::~MutationObserver() = default;
JS::ThrowCompletionOr<void> MutationObserver::initialize(JS::Realm& realm)
void MutationObserver::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::MutationObserverPrototype>(realm, "MutationObserver"));
return {};
}
void MutationObserver::visit_edges(Cell::Visitor& visitor)

View file

@ -51,7 +51,7 @@ public:
private:
MutationObserver(JS::Realm&, JS::GCPtr<WebIDL::CallbackType>);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
// https://dom.spec.whatwg.org/#concept-mo-callback

View file

@ -33,12 +33,10 @@ MutationRecord::MutationRecord(JS::Realm& realm, FlyString const& type, Node con
MutationRecord::~MutationRecord() = default;
JS::ThrowCompletionOr<void> MutationRecord::initialize(JS::Realm& realm)
void MutationRecord::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::MutationRecordPrototype>(realm, "MutationRecord"));
return {};
}
void MutationRecord::visit_edges(Cell::Visitor& visitor)

View file

@ -33,7 +33,7 @@ public:
private:
MutationRecord(JS::Realm& realm, FlyString const& type, Node const& target, NodeList& added_nodes, NodeList& removed_nodes, Node* previous_sibling, Node* next_sibling, DeprecatedString const& attribute_name, DeprecatedString const& attribute_namespace, DeprecatedString const& old_value);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
FlyString m_type;

View file

@ -25,12 +25,10 @@ NamedNodeMap::NamedNodeMap(Element& element)
{
}
JS::ThrowCompletionOr<void> NamedNodeMap::initialize(JS::Realm& realm)
void NamedNodeMap::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::NamedNodeMapPrototype>(realm, "NamedNodeMap"));
return {};
}
void NamedNodeMap::visit_edges(Cell::Visitor& visitor)

View file

@ -56,7 +56,7 @@ public:
private:
explicit NamedNodeMap(Element&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
// ^Bindings::LegacyPlatformObject

View file

@ -21,12 +21,10 @@ NodeIterator::NodeIterator(Node& root)
NodeIterator::~NodeIterator() = default;
JS::ThrowCompletionOr<void> NodeIterator::initialize(JS::Realm& realm)
void NodeIterator::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::NodeIteratorPrototype>(realm, "NodeIterator"));
return {};
}
void NodeIterator::finalize()

View file

@ -37,7 +37,7 @@ public:
private:
explicit NodeIterator(Node& root);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
virtual void finalize() override;

View file

@ -17,12 +17,10 @@ NodeList::NodeList(JS::Realm& realm)
NodeList::~NodeList() = default;
JS::ThrowCompletionOr<void> NodeList::initialize(JS::Realm& realm)
void NodeList::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::NodeListPrototype>(realm, "NodeList"));
return {};
}
WebIDL::ExceptionOr<JS::Value> NodeList::item_value(size_t index) const

View file

@ -27,7 +27,7 @@ public:
protected:
explicit NodeList(JS::Realm&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
// ^Bindings::LegacyPlatformObject
virtual bool supports_indexed_properties() const final override { return true; }

View file

@ -17,12 +17,10 @@ ProcessingInstruction::ProcessingInstruction(Document& document, DeprecatedStrin
{
}
JS::ThrowCompletionOr<void> ProcessingInstruction::initialize(JS::Realm& realm)
void ProcessingInstruction::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::ProcessingInstructionPrototype>(realm, "ProcessingInstruction"));
return {};
}
}

View file

@ -24,7 +24,7 @@ public:
private:
ProcessingInstruction(Document&, DeprecatedString const& data, DeprecatedString const& target);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
DeprecatedString m_target;
};

View file

@ -70,12 +70,10 @@ Range::~Range()
live_ranges().remove(this);
}
JS::ThrowCompletionOr<void> Range::initialize(JS::Realm& realm)
void Range::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::RangePrototype>(realm, "Range"));
return {};
}
void Range::visit_edges(Cell::Visitor& visitor)

View file

@ -95,7 +95,7 @@ private:
explicit Range(Document&);
Range(Node& start_container, u32 start_offset, Node& end_container, u32 end_offset);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
Node& root();

View file

@ -19,11 +19,10 @@ ShadowRoot::ShadowRoot(Document& document, Element& host, Bindings::ShadowRootMo
set_host(&host);
}
JS::ThrowCompletionOr<void> ShadowRoot::initialize(JS::Realm& realm)
void ShadowRoot::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::ShadowRootPrototype>(realm, "ShadowRoot"));
return {};
}
// https://dom.spec.whatwg.org/#ref-for-get-the-parent%E2%91%A6

View file

@ -31,7 +31,7 @@ public:
private:
ShadowRoot(Document&, Element& host, Bindings::ShadowRootMode);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
// ^Node
virtual DeprecatedFlyString node_name() const override { return "#shadow-root"; }

View file

@ -35,12 +35,10 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<StaticRange>> StaticRange::construct_impl(J
return MUST_OR_THROW_OOM(realm.heap().allocate<StaticRange>(realm, *init.start_container, init.start_offset, *init.end_container, init.end_offset));
}
JS::ThrowCompletionOr<void> StaticRange::initialize(JS::Realm& realm)
void StaticRange::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::StaticRangePrototype>(realm, "StaticRange"));
return {};
}
}

View file

@ -29,7 +29,7 @@ public:
StaticRange(Node& start_container, u32 start_offset, Node& end_container, u32 end_offset);
virtual ~StaticRange() override;
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
};
}

View file

@ -24,12 +24,10 @@ Text::Text(Document& document, NodeType type, DeprecatedString const& data)
{
}
JS::ThrowCompletionOr<void> Text::initialize(JS::Realm& realm)
void Text::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::TextPrototype>(realm, "Text"));
return {};
}
void Text::visit_edges(Cell::Visitor& visitor)

View file

@ -38,7 +38,7 @@ protected:
Text(Document&, DeprecatedString const&);
Text(Document&, NodeType, DeprecatedString const&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
private:

View file

@ -22,12 +22,10 @@ TreeWalker::TreeWalker(Node& root)
TreeWalker::~TreeWalker() = default;
JS::ThrowCompletionOr<void> TreeWalker::initialize(JS::Realm& realm)
void TreeWalker::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::TreeWalkerPrototype>(realm, "TreeWalker"));
return {};
}
void TreeWalker::visit_edges(Cell::Visitor& visitor)

View file

@ -39,7 +39,7 @@ public:
private:
explicit TreeWalker(Node& root);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
enum class ChildTraversalType {

View file

@ -14,12 +14,10 @@ XMLDocument::XMLDocument(JS::Realm& realm, AK::URL const& url)
{
}
JS::ThrowCompletionOr<void> XMLDocument::initialize(JS::Realm& realm)
void XMLDocument::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::XMLDocumentPrototype>(realm, "XMLDocument"));
return {};
}
}

View file

@ -19,7 +19,7 @@ public:
private:
XMLDocument(JS::Realm& realm, AK::URL const& url);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
};
}