RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:47:34 +00:00
Code Issues Activity Actions

LibJS: Make Cell::initialize() return void

Browse source 
Stop worrying about tiny OOMs.

Work towards #20405
This commit is contained in:
Andreas Kling 2023-08-07 08:41:28 +02:00
parent fde26c53f0
commit 18c54d8d40
804 changed files with 1330 additions and 2171 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/Geometry/DOMMatrix.cpp
View file

@ -67,12 +67,10 @@ DOMMatrix::DOMMatrix(JS::Realm& realm, DOMMatrixReadOnly const& read_only_matrix
DOMMatrix::~DOMMatrix() = default;
JS::ThrowCompletionOr<void> DOMMatrix::initialize(JS::Realm& realm)
void DOMMatrix::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DOMMatrixPrototype>(realm, "DOMMatrix"));
return {};
}
// https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-m11

2
Userland/Libraries/LibWeb/Geometry/DOMMatrix.h
View file

@ -52,7 +52,7 @@ private:
DOMMatrix(JS::Realm&, Optional<Variant<String, Vector<double>>> const& init);
DOMMatrix(JS::Realm&, DOMMatrixReadOnly const& read_only_matrix);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
};
}

6
Userland/Libraries/LibWeb/Geometry/DOMMatrixReadOnly.cpp
View file

@ -107,12 +107,10 @@ DOMMatrixReadOnly::DOMMatrixReadOnly(JS::Realm& realm, DOMMatrixReadOnly const&
DOMMatrixReadOnly::~DOMMatrixReadOnly() = default;
JS::ThrowCompletionOr<void> DOMMatrixReadOnly::initialize(JS::Realm& realm)
void DOMMatrixReadOnly::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DOMMatrixReadOnlyPrototype>(realm, "DOMMatrixReadOnly"));
return {};
}
// https://drafts.fxtf.org/geometry/#create-a-2d-matrix

2
Userland/Libraries/LibWeb/Geometry/DOMMatrixReadOnly.h
View file

@ -98,7 +98,7 @@ private:
void initialize_from_create_2d_matrix(double m11, double m12, double m21, double m22, double m41, double m42);
void initialize_from_create_3d_matrix(double m11, double m12, double m13, double m14, double m21, double m22, double m23, double m24, double m31, double m32, double m33, double m34, double m41, double m42, double m43, double m44);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
};
WebIDL::ExceptionOr<void> validate_and_fixup_dom_matrix_2d_init(DOMMatrix2DInit& init);

6
Userland/Libraries/LibWeb/Geometry/DOMPoint.cpp
View file

@ -30,12 +30,10 @@ JS::NonnullGCPtr<DOMPoint> DOMPoint::from_point(JS::VM& vm, DOMPointInit const&
DOMPoint::~DOMPoint() = default;
JS::ThrowCompletionOr<void> DOMPoint::initialize(JS::Realm& realm)
void DOMPoint::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DOMPointPrototype>(realm, "DOMPoint"));
return {};
}
}

2
Userland/Libraries/LibWeb/Geometry/DOMPoint.h
View file

@ -35,7 +35,7 @@ public:
private:
DOMPoint(JS::Realm&, double x, double y, double z, double w);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
};
}

6
Userland/Libraries/LibWeb/Geometry/DOMPointReadOnly.cpp
View file

@ -34,12 +34,10 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<DOMPointReadOnly>> DOMPointReadOnly::from_p
DOMPointReadOnly::~DOMPointReadOnly() = default;
JS::ThrowCompletionOr<void> DOMPointReadOnly::initialize(JS::Realm& realm)
void DOMPointReadOnly::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DOMPointReadOnlyPrototype>(realm, "DOMPointReadOnly"));
return {};
}
}

2
Userland/Libraries/LibWeb/Geometry/DOMPointReadOnly.h
View file

@ -39,7 +39,7 @@ public:
protected:
DOMPointReadOnly(JS::Realm&, double x, double y, double z, double w);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
double m_x;
double m_y;

6
Userland/Libraries/LibWeb/Geometry/DOMRect.cpp
View file

@ -34,12 +34,10 @@ DOMRect::DOMRect(JS::Realm& realm, double x, double y, double width, double heig
DOMRect::~DOMRect() = default;
JS::ThrowCompletionOr<void> DOMRect::initialize(JS::Realm& realm)
void DOMRect::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DOMRectPrototype>(realm, "DOMRect"));
return {};
}
}

2
Userland/Libraries/LibWeb/Geometry/DOMRect.h
View file

@ -34,7 +34,7 @@ public:
private:
DOMRect(JS::Realm&, double x, double y, double width, double height);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
};
}

6
Userland/Libraries/LibWeb/Geometry/DOMRectList.cpp
View file

@ -28,12 +28,10 @@ DOMRectList::DOMRectList(JS::Realm& realm, Vector<JS::NonnullGCPtr<DOMRect>> rec
DOMRectList::~DOMRectList() = default;
JS::ThrowCompletionOr<void> DOMRectList::initialize(JS::Realm& realm)
void DOMRectList::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DOMRectListPrototype>(realm, "DOMRectList"));
return {};
}
// https://drafts.fxtf.org/geometry-1/#dom-domrectlist-length

2
Userland/Libraries/LibWeb/Geometry/DOMRectList.h
View file

@ -31,7 +31,7 @@ public:
private:
DOMRectList(JS::Realm&, Vector<JS::NonnullGCPtr<DOMRect>>);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
// ^Bindings::LegacyPlatformObject
virtual bool supports_indexed_properties() const override { return true; }

6
Userland/Libraries/LibWeb/Geometry/DOMRectReadOnly.cpp
View file

@ -30,12 +30,10 @@ DOMRectReadOnly::DOMRectReadOnly(JS::Realm& realm, double x, double y, double wi
DOMRectReadOnly::~DOMRectReadOnly() = default;
JS::ThrowCompletionOr<void> DOMRectReadOnly::initialize(JS::Realm& realm)
void DOMRectReadOnly::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DOMRectReadOnlyPrototype>(realm, "DOMRectReadOnly"));
return {};
}
}

2
Userland/Libraries/LibWeb/Geometry/DOMRectReadOnly.h
View file

@ -43,7 +43,7 @@ public:
protected:
DOMRectReadOnly(JS::Realm&, double x, double y, double width, double height);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
Gfx::FloatRect m_rect;
};