RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-15 09:14:58 +00:00
Code Issues Activity Actions

LibJS: Make Cell::initialize() return void

Browse source 
Stop worrying about tiny OOMs.

Work towards #20405
This commit is contained in:
Andreas Kling 2023-08-07 08:41:28 +02:00
parent fde26c53f0
commit 18c54d8d40
804 changed files with 1330 additions and 2171 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View file

@ -47,14 +47,14 @@ HTMLMediaElement::HTMLMediaElement(DOM::Document& document, DOM::QualifiedName q
HTMLMediaElement::~HTMLMediaElement() = default;
JS::ThrowCompletionOr<void> HTMLMediaElement::initialize(JS::Realm& realm)
void HTMLMediaElement::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::HTMLMediaElementPrototype>(realm, "HTMLMediaElement"));
m_audio_tracks = TRY(realm.heap().allocate<AudioTrackList>(realm, realm));
m_video_tracks = TRY(realm.heap().allocate<VideoTrackList>(realm, realm));
m_document_observer = TRY(realm.heap().allocate<DOM::DocumentObserver>(realm, realm, document()));
m_audio_tracks = MUST(realm.heap().allocate<AudioTrackList>(realm, realm));
m_video_tracks = MUST(realm.heap().allocate<VideoTrackList>(realm, realm));
m_document_observer = MUST(realm.heap().allocate<DOM::DocumentObserver>(realm, realm, document()));
// https://html.spec.whatwg.org/multipage/media.html#playing-the-media-resource:media-element-82
m_document_observer->document_became_inactive = [this]() {
@ -62,8 +62,6 @@ JS::ThrowCompletionOr<void> HTMLMediaElement::initialize(JS::Realm& realm)
// the document is active again.
pause_element().release_value_but_fixme_should_propagate_errors();
};
return {};
}
// https://html.spec.whatwg.org/multipage/media.html#queue-a-media-element-task