RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-21 15:25:07 +00:00
Code Issues Activity Actions

LibJS: Make Cell::initialize() return void

Browse source 
Stop worrying about tiny OOMs.

Work towards #20405
This commit is contained in:
Andreas Kling 2023-08-07 08:41:28 +02:00
parent fde26c53f0
commit 18c54d8d40
804 changed files with 1330 additions and 2171 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/Location.cpp
View file

@ -36,9 +36,9 @@ void Location::visit_edges(Cell::Visitor& visitor)
visitor.visit(property);
}
JS::ThrowCompletionOr<void> Location::initialize(JS::Realm& realm)
void Location::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Object::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::LocationPrototype>(realm, "Location"));
// FIXME: Implement steps 2.-4.
@ -46,8 +46,6 @@ JS::ThrowCompletionOr<void> Location::initialize(JS::Realm& realm)
// 5. Set the value of the [[DefaultProperties]] internal slot of location to location.[[OwnPropertyKeys]]().
// NOTE: In LibWeb this happens before the ESO is set up, so we must avoid location's custom [[OwnPropertyKeys]].
m_default_properties.extend(MUST(Object::internal_own_property_keys()));
return {};
}
// https://html.spec.whatwg.org/multipage/history.html#relevant-document