RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:27:46 +00:00
Code Issues Activity Actions

LibJS: Make Cell::initialize() return void

Browse source 
Stop worrying about tiny OOMs.

Work towards #20405
This commit is contained in:
Andreas Kling 2023-08-07 08:41:28 +02:00
parent fde26c53f0
commit 18c54d8d40
804 changed files with 1330 additions and 2171 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/URL/URL.cpp
View file

@ -84,12 +84,10 @@ URL::URL(JS::Realm& realm, AK::URL url, JS::NonnullGCPtr<URLSearchParams> query)
URL::~URL() = default;
JS::ThrowCompletionOr<void> URL::initialize(JS::Realm& realm)
void URL::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::URLPrototype>(realm, "URL"));
return {};
}
void URL::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/URL/URL.h
View file

@ -70,7 +70,7 @@ public:
private:
URL(JS::Realm&, AK::URL, JS::NonnullGCPtr<URLSearchParams> query);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
AK::URL m_url;

6
Userland/Libraries/LibWeb/URL/URLSearchParams.cpp
View file

@ -25,12 +25,10 @@ URLSearchParams::URLSearchParams(JS::Realm& realm, Vector<QueryParam> list)
URLSearchParams::~URLSearchParams() = default;
JS::ThrowCompletionOr<void> URLSearchParams::initialize(JS::Realm& realm)
void URLSearchParams::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::URLSearchParamsPrototype>(realm, "URLSearchParams"));
return {};
}
void URLSearchParams::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/URL/URLSearchParams.h
View file

@ -49,7 +49,7 @@ private:
URLSearchParams(JS::Realm&, Vector<QueryParam> list);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
WebIDL::ExceptionOr<void> update();

6
Userland/Libraries/LibWeb/URL/URLSearchParamsIterator.cpp
View file

@ -37,12 +37,10 @@ URLSearchParamsIterator::URLSearchParamsIterator(URLSearchParams const& url_sear
URLSearchParamsIterator::~URLSearchParamsIterator() = default;
JS::ThrowCompletionOr<void> URLSearchParamsIterator::initialize(JS::Realm& realm)
void URLSearchParamsIterator::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::URLSearchParamsIteratorPrototype>(realm, "URLSearchParamsIterator"));
return {};
}
void URLSearchParamsIterator::visit_edges(JS::Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/URL/URLSearchParamsIterator.h
View file

@ -24,7 +24,7 @@ public:
private:
URLSearchParamsIterator(URLSearchParams const&, JS::Object::PropertyKind iteration_kind);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
JS::NonnullGCPtr<URLSearchParams const> m_url_search_params;