RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 10:47:35 +00:00
Code Issues Activity Actions

LibJS: Make Cell::initialize() return void

Browse source 
Stop worrying about tiny OOMs.

Work towards #20405
This commit is contained in:
Andreas Kling 2023-08-07 08:41:28 +02:00
parent fde26c53f0
commit 18c54d8d40
804 changed files with 1330 additions and 2171 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/XHR/FormData.cpp
View file

@ -46,12 +46,10 @@ FormData::FormData(JS::Realm& realm, Vector<FormDataEntry> entry_list)
FormData::~FormData() = default;
JS::ThrowCompletionOr<void> FormData::initialize(JS::Realm& realm)
void FormData::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::FormDataPrototype>(realm, "FormData"));
return {};
}
// https://xhr.spec.whatwg.org/#dom-formdata-append

2
Userland/Libraries/LibWeb/XHR/FormData.h
View file

@ -51,7 +51,7 @@ private:
explicit FormData(JS::Realm&, Vector<FormDataEntry> entry_list = {});
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
WebIDL::ExceptionOr<void> append_impl(String const& name, Variant<JS::NonnullGCPtr<FileAPI::Blob>, String> const& value, Optional<String> const& filename = {});
WebIDL::ExceptionOr<void> set_impl(String const& name, Variant<JS::NonnullGCPtr<FileAPI::Blob>, String> const& value, Optional<String> const& filename = {});

6
Userland/Libraries/LibWeb/XHR/FormDataIterator.cpp
View file

@ -37,12 +37,10 @@ FormDataIterator::FormDataIterator(Web::XHR::FormData const& form_data, JS::Obje
FormDataIterator::~FormDataIterator() = default;
JS::ThrowCompletionOr<void> FormDataIterator::initialize(JS::Realm& realm)
void FormDataIterator::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::FormDataIteratorPrototype>(realm, "FormDataIterator"));
return {};
}
void FormDataIterator::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/XHR/FormDataIterator.h
View file

@ -24,7 +24,7 @@ public:
private:
FormDataIterator(FormData const&, JS::Object::PropertyKind iterator_kind);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
JS::NonnullGCPtr<FormData const> m_form_data;

6
Userland/Libraries/LibWeb/XHR/ProgressEvent.cpp
View file

@ -29,12 +29,10 @@ ProgressEvent::ProgressEvent(JS::Realm& realm, FlyString const& event_name, Prog
ProgressEvent::~ProgressEvent() = default;
JS::ThrowCompletionOr<void> ProgressEvent::initialize(JS::Realm& realm)
void ProgressEvent::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::ProgressEventPrototype>(realm, "ProgressEvent"));
return {};
}
}

2
Userland/Libraries/LibWeb/XHR/ProgressEvent.h
View file

@ -36,7 +36,7 @@ public:
private:
ProgressEvent(JS::Realm&, FlyString const& event_name, ProgressEventInit const& event_init);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
bool m_length_computable { false };
u64 m_loaded { 0 };

6
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp
View file

@ -71,12 +71,10 @@ XMLHttpRequest::XMLHttpRequest(JS::Realm& realm, XMLHttpRequestUpload& upload_ob
XMLHttpRequest::~XMLHttpRequest() = default;
JS::ThrowCompletionOr<void> XMLHttpRequest::initialize(JS::Realm& realm)
void XMLHttpRequest::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::XMLHttpRequestPrototype>(realm, "XMLHttpRequest"));
return {};
}
void XMLHttpRequest::visit_edges(Cell::Visitor& visitor)

2
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.h
View file

@ -77,7 +77,7 @@ public:
JS::NonnullGCPtr<XMLHttpRequestUpload> upload() const;
private:
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
virtual bool must_survive_garbage_collection() const override;

6
Userland/Libraries/LibWeb/XHR/XMLHttpRequestUpload.cpp
View file

@ -17,12 +17,10 @@ XMLHttpRequestUpload::XMLHttpRequestUpload(JS::Realm& realm)
XMLHttpRequestUpload::~XMLHttpRequestUpload() = default;
JS::ThrowCompletionOr<void> XMLHttpRequestUpload::initialize(JS::Realm& realm)
void XMLHttpRequestUpload::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::XMLHttpRequestUploadPrototype>(realm, "XMLHttpRequestUpload"));
return {};
}
}

2
Userland/Libraries/LibWeb/XHR/XMLHttpRequestUpload.h
View file

@ -19,7 +19,7 @@ public:
private:
XMLHttpRequestUpload(JS::Realm&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
};
}