RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 09:22:44 +00:00
Code Issues Activity Actions

LibJS: Make Cell::initialize() return void

Browse source 
Stop worrying about tiny OOMs.

Work towards #20405
This commit is contained in:
Andreas Kling 2023-08-07 08:41:28 +02:00
parent fde26c53f0
commit 18c54d8d40
804 changed files with 1330 additions and 2171 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Utilities/js.cpp
View file

@ -41,7 +41,7 @@ public:
: GlobalObject(realm)
{
}
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual ~ReplObject() override = default;
private:
@ -62,7 +62,7 @@ public:
: JS::GlobalObject(realm)
{
}
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void initialize(JS::Realm&) override;
virtual ~ScriptObject() override = default;
private:
@ -346,9 +346,9 @@ static JS::ThrowCompletionOr<JS::Value> load_json_impl(JS::VM& vm)
return JS::JSONObject::parse_json_value(vm, json.value());
}
JS::ThrowCompletionOr<void> ReplObject::initialize(JS::Realm& realm)
void ReplObject::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
define_direct_property("global", this, JS::Attribute::Enumerable);
u8 attr = JS::Attribute::Configurable | JS::Attribute::Writable | JS::Attribute::Enumerable;
@ -378,8 +378,6 @@ JS::ThrowCompletionOr<void> ReplObject::initialize(JS::Realm& realm)
return value;
},
attr);
return {};
}
JS_DEFINE_NATIVE_FUNCTION(ReplObject::save_to_file)
@ -434,17 +432,15 @@ JS_DEFINE_NATIVE_FUNCTION(ReplObject::print)
return JS::js_undefined();
}
JS::ThrowCompletionOr<void> ScriptObject::initialize(JS::Realm& realm)
void ScriptObject::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
Base::initialize(realm);
define_direct_property("global", this, JS::Attribute::Enumerable);
u8 attr = JS::Attribute::Configurable | JS::Attribute::Writable | JS::Attribute::Enumerable;
define_native_function(realm, "loadINI", load_ini, 1, attr);
define_native_function(realm, "loadJSON", load_json, 1, attr);
define_native_function(realm, "print", print, 1, attr);
return {};
}
JS_DEFINE_NATIVE_FUNCTION(ScriptObject::load_ini)