RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:48:14 +00:00
Code Issues Activity Actions

LibWeb: Skip StackingContext with erroneously large rect in GPU painter

Browse source 
If the GPU painter encounters a stacking context that requires the
allocation of a framebuffer so large, it is likely due to a layout
mistake, for now, we can skip it instead of crashing because of a
failed allocation.

Fixes https://github.com/SerenityOS/serenity/issues/22608
This commit is contained in:
Aliaksandr Kalenik 2024-02-26 06:09:29 +01:00 • committed by Andreas Kling
parent 6d48b6724d
commit 18d26142f0
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/Painting/CommandExecutorGPU.cpp
View file

@ -93,6 +93,13 @@ CommandResult CommandExecutorGPU::push_stacking_context(float opacity, bool is_f
if (source_paintable_rect.is_empty())
return CommandResult::SkipStackingContext;
// If, due to layout mistakes, we encounter an excessively large rectangle here, it must be skipped to prevent
// framebuffer allocation failure.
if (source_paintable_rect.width() > 10000 || source_paintable_rect.height() > 10000) {
dbgln("FIXME: Skipping stacking context with excessively large paintable rect: {}", source_paintable_rect);
return CommandResult::SkipStackingContext;
}
m_stacking_contexts.last().stacking_context_depth++;
painter().save();
if (is_fixed_position) {