RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:27:43 +00:00
Code Issues Activity Actions

LibCore: Link against LibSystem

Browse source 
Depending on what OS LibCore is being built for (either SerenityOS or
not-SerenityOS), the library does not just wrap functions from LibC,
but it also implements syscalls itself. Therefore, it needs to link
against LibSystem, as that is the only library that is allowed to do
syscalls.

When cross-compiling the OS this is currently not an issue because
LibC links against LibSystem, and CMake passes that dependency through
transitively by accident. However, on Lagom, LibC is just a dummy
INTERFACE library, so the LibSystem dependency is never pulled in,
resulting in undefined symbols whenever we build LibCore on SerenityOS
as a part of Lagom.
This commit is contained in:
Tim Schumacher 2022-10-23 22:52:06 +00:00 • committed by Linus Groh
parent 4ee0737d10
commit 18e2bc635f
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCore/CMakeLists.txt
View file

@ -45,4 +45,4 @@ if (NOT ANDROID AND NOT WIN32)
endif()
serenity_lib(LibCore core)
target_link_libraries(LibCore LibC LibCrypt)
target_link_libraries(LibCore LibC LibCrypt LibSystem)