RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:58:11 +00:00
Code Issues Activity Actions

HackStudio: Don't crash when navigating backtrace with up/down keys

Browse source 
It's up to BacktraceModel::index() to validate its inputs.
This commit is contained in:
Andreas Kling 2020-05-12 15:04:12 +02:00
parent 575b674081
commit 18ff75e67b
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
DevTools/HackStudio/Debugger/BacktraceModel.cpp
View file

@ -41,6 +41,13 @@ GUI::Variant BacktraceModel::data(const GUI::ModelIndex& index, Role role) const
return {}; return {};
} }
GUI::ModelIndex BacktraceModel::index(int row, int column, const GUI::ModelIndex&) const
{
if (row < 0 || row >= static_cast<int>(m_frames.size()))
return {};
return create_index(row, column, &m_frames.at(row));
}
Vector<BacktraceModel::FrameInfo> BacktraceModel::create_backtrace(const DebugSession& debug_session, const PtraceRegisters& regs) Vector<BacktraceModel::FrameInfo> BacktraceModel::create_backtrace(const DebugSession& debug_session, const PtraceRegisters& regs)
{ {
u32 current_ebp = regs.ebp; u32 current_ebp = regs.ebp;

2
DevTools/HackStudio/Debugger/BacktraceModel.h
View file

@ -47,7 +47,7 @@ public:
virtual GUI::Variant data(const GUI::ModelIndex& index, Role role = Role::Display) const override; virtual GUI::Variant data(const GUI::ModelIndex& index, Role role = Role::Display) const override;
virtual void update() override {} virtual void update() override {}
virtual GUI::ModelIndex index(int row, int column = 0, const GUI::ModelIndex& = GUI::ModelIndex()) const override { return create_index(row, column, &m_frames.at(row)); } virtual GUI::ModelIndex index(int row, int column, const GUI::ModelIndex&) const override;
struct FrameInfo { struct FrameInfo {
String function_name; String function_name;