RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:17:34 +00:00
Code Issues Activity Actions

Kernel: Simplify Mount internals

Browse source 
- The host custody never changes after initialization, so there's no
  need to protect it with a spinlock.

- To enforce the fact that some members don't change after
  initialization, make them const.
This commit is contained in:
Andreas Kling 2023-04-02 18:19:20 +02:00
parent 673592dea8
commit 19084ef743
2 changed files with 27 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Kernel/FileSystem/Mount.h
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2018-2023, Andreas Kling <kling@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -17,11 +17,13 @@ namespace Kernel {
class VirtualFileSystem;
class Mount {
AK_MAKE_NONCOPYABLE(Mount);
AK_MAKE_NONMOVABLE(Mount);
friend class VirtualFileSystem;
public:
Mount(NonnullRefPtr<FileSystem>, Custody* host_custody, int flags);
Mount(Inode& source, Custody& host_custody, int flags);
Mount(NonnullRefPtr<FileSystem>, RefPtr<Custody> host_custody, int flags);
Mount(NonnullRefPtr<Inode> source, NonnullRefPtr<Custody> host_custody, int flags);
RefPtr<Inode const> host() const;
RefPtr<Inode> host();
@ -38,10 +40,10 @@ public:
void set_flags(int flags) { m_flags = flags; }
private:
NonnullRefPtr<Inode> m_guest;
NonnullRefPtr<FileSystem> m_guest_fs;
SpinlockProtected<RefPtr<Custody>, LockRank::None> m_host_custody;
int m_flags;
NonnullRefPtr<FileSystem> const m_guest_fs;
NonnullRefPtr<Inode> const m_guest;
RefPtr<Custody> const m_host_custody;
int m_flags { 0 };
IntrusiveListNode<Mount> m_vfs_list_node;
};