From 190cf1507b88d25d04148d983d72a378035b05e9 Mon Sep 17 00:00:00 2001 From: Lenny Maiorani Date: Wed, 16 Mar 2022 13:15:15 -0600 Subject: [PATCH] Kernel: Use default constructors/destructors https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules "The compiler is more likely to get the default semantics right and you cannot implement these functions better than the compiler." --- Kernel/Arch/aarch64/ScopedCritical.cpp | 9 ++----- Kernel/Arch/aarch64/SmapDisabler.cpp | 4 +--- Kernel/Bus/USB/SysFSUSB.cpp | 4 +--- Kernel/Bus/USB/UHCI/UHCIController.cpp | 4 +--- Kernel/Bus/USB/USBDevice.cpp | 4 +--- Kernel/Bus/USB/USBTransfer.cpp | 4 +--- Kernel/Bus/VirtIO/Queue.cpp | 4 +--- Kernel/Devices/Audio/AC97.cpp | 4 +--- Kernel/Devices/Audio/Channel.h | 2 +- Kernel/Devices/BlockDevice.cpp | 4 +--- Kernel/Devices/CharacterDevice.cpp | 4 +--- Kernel/Devices/ConsoleDevice.cpp | 4 +--- Kernel/Devices/DeviceControlDevice.cpp | 4 +--- Kernel/Devices/FullDevice.cpp | 4 +--- Kernel/Devices/HID/KeyboardDevice.cpp | 4 +--- Kernel/Devices/HID/MouseDevice.cpp | 4 +--- Kernel/Devices/HID/PS2KeyboardDevice.cpp | 4 +--- Kernel/Devices/HID/PS2MouseDevice.cpp | 4 +--- Kernel/Devices/HID/VMWareMouseDevice.cpp | 4 +--- Kernel/Devices/MemoryDevice.cpp | 4 +--- Kernel/Devices/NullDevice.cpp | 4 +--- Kernel/Devices/RandomDevice.cpp | 4 +--- Kernel/Devices/SerialDevice.cpp | 4 +--- Kernel/Devices/ZeroDevice.cpp | 4 +--- Kernel/FileSystem/AnonymousFile.cpp | 4 +--- Kernel/FileSystem/BlockBasedFileSystem.cpp | 4 +--- Kernel/FileSystem/Custody.cpp | 4 +--- Kernel/FileSystem/DevPtsFS.cpp | 13 +++------- Kernel/FileSystem/DevTmpFS.cpp | 24 +++++-------------- Kernel/FileSystem/Ext2FileSystem.cpp | 4 +--- Kernel/FileSystem/FIFO.cpp | 4 +--- Kernel/FileSystem/File.cpp | 9 ++----- Kernel/FileSystem/FileBackedFileSystem.cpp | 4 +--- Kernel/FileSystem/ISO9660FileSystem.cpp | 8 ++----- Kernel/FileSystem/InodeFile.cpp | 4 +--- Kernel/FileSystem/Plan9FileSystem.cpp | 4 +--- Kernel/FileSystem/ProcFS.cpp | 17 ++++--------- Kernel/FileSystem/SysFS.cpp | 13 +++------- Kernel/FileSystem/TmpFS.cpp | 13 +++------- Kernel/FileSystem/VirtualFileSystem.cpp | 4 +--- Kernel/FutexQueue.cpp | 9 ++----- Kernel/GlobalProcessExposed.cpp | 4 +--- Kernel/Graphics/Console/Console.h | 2 +- .../Graphics/VirtIOGPU/FramebufferDevice.cpp | 4 +--- Kernel/Interrupts/IRQHandler.cpp | 4 +--- .../Interrupts/SpuriousInterruptHandler.cpp | 4 +--- .../Interrupts/UnhandledInterruptHandler.cpp | 4 +--- Kernel/Memory/AddressSpace.cpp | 4 +--- Kernel/Memory/AnonymousVMObject.cpp | 8 ++----- Kernel/Memory/InodeVMObject.cpp | 4 +--- Kernel/Memory/MemoryManager.cpp | 4 +--- Kernel/Memory/PageDirectory.cpp | 4 +--- Kernel/Memory/PhysicalRegion.cpp | 4 +--- Kernel/Memory/PrivateInodeVMObject.cpp | 4 +--- Kernel/Net/Intel/E1000ENetworkAdapter.cpp | 4 +--- Kernel/Net/Intel/E1000NetworkAdapter.cpp | 4 +--- Kernel/Net/LoopbackAdapter.cpp | 4 +--- Kernel/Net/NE2000/NetworkAdapter.cpp | 4 +--- Kernel/Net/NetworkAdapter.cpp | 4 +--- Kernel/Net/Realtek/RTL8139NetworkAdapter.cpp | 4 +--- Kernel/Net/Realtek/RTL8168NetworkAdapter.cpp | 4 +--- Kernel/Net/Socket.cpp | 4 +--- Kernel/ProcessExposed.cpp | 4 +--- Kernel/Storage/ATA/AHCIController.cpp | 4 +--- Kernel/Storage/ATA/AHCIPortHandler.cpp | 4 +--- Kernel/Storage/ATA/ATADevice.cpp | 4 +--- Kernel/Storage/ATA/ATADiskDevice.cpp | 4 +--- Kernel/Storage/ATA/ATAPIDiscDevice.cpp | 4 +--- Kernel/Storage/ATA/IDEChannel.cpp | 4 +--- Kernel/Storage/ATA/IDEController.cpp | 4 +--- Kernel/Storage/NVMe/NVMeQueue.cpp | 4 +--- Kernel/Storage/Partition/DiskPartition.cpp | 4 +--- .../Storage/Partition/EBRPartitionTable.cpp | 4 +--- .../Storage/Partition/MBRPartitionTable.cpp | 4 +--- Kernel/Storage/RamdiskController.cpp | 4 +--- Kernel/Storage/RamdiskDevice.cpp | 4 +--- Kernel/TTY/PTYMultiplexer.cpp | 4 +--- Kernel/TTY/TTY.cpp | 4 +--- Kernel/ThreadBlockers.cpp | 20 ++++------------ 79 files changed, 102 insertions(+), 309 deletions(-) diff --git a/Kernel/Arch/aarch64/ScopedCritical.cpp b/Kernel/Arch/aarch64/ScopedCritical.cpp index 47650112a4..eb64fa2377 100644 --- a/Kernel/Arch/aarch64/ScopedCritical.cpp +++ b/Kernel/Arch/aarch64/ScopedCritical.cpp @@ -10,13 +10,8 @@ namespace Kernel { -ScopedCritical::ScopedCritical() -{ -} - -ScopedCritical::~ScopedCritical() -{ -} +ScopedCritical::ScopedCritical() = default; +ScopedCritical::~ScopedCritical() = default; ScopedCritical::ScopedCritical(ScopedCritical&& /*from*/) { diff --git a/Kernel/Arch/aarch64/SmapDisabler.cpp b/Kernel/Arch/aarch64/SmapDisabler.cpp index 80c8e93503..cb2be2bae5 100644 --- a/Kernel/Arch/aarch64/SmapDisabler.cpp +++ b/Kernel/Arch/aarch64/SmapDisabler.cpp @@ -13,8 +13,6 @@ SmapDisabler::SmapDisabler() { } -SmapDisabler::~SmapDisabler() -{ -} +SmapDisabler::~SmapDisabler() = default; } diff --git a/Kernel/Bus/USB/SysFSUSB.cpp b/Kernel/Bus/USB/SysFSUSB.cpp index 567910bdee..b9c62d6c98 100644 --- a/Kernel/Bus/USB/SysFSUSB.cpp +++ b/Kernel/Bus/USB/SysFSUSB.cpp @@ -20,9 +20,7 @@ SysFSUSBDeviceInformation::SysFSUSBDeviceInformation(NonnullOwnPtr devi { } -SysFSUSBDeviceInformation::~SysFSUSBDeviceInformation() -{ -} +SysFSUSBDeviceInformation::~SysFSUSBDeviceInformation() = default; ErrorOr SysFSUSBDeviceInformation::try_generate(KBufferBuilder& builder) { diff --git a/Kernel/Bus/USB/UHCI/UHCIController.cpp b/Kernel/Bus/USB/UHCI/UHCIController.cpp index 403ac08888..f478cd6622 100644 --- a/Kernel/Bus/USB/UHCI/UHCIController.cpp +++ b/Kernel/Bus/USB/UHCI/UHCIController.cpp @@ -89,9 +89,7 @@ UNMAP_AFTER_INIT UHCIController::UHCIController(PCI::DeviceIdentifier const& pci { } -UNMAP_AFTER_INIT UHCIController::~UHCIController() -{ -} +UNMAP_AFTER_INIT UHCIController::~UHCIController() = default; ErrorOr UHCIController::reset() { diff --git a/Kernel/Bus/USB/USBDevice.cpp b/Kernel/Bus/USB/USBDevice.cpp index 25b207545d..73257b20ea 100644 --- a/Kernel/Bus/USB/USBDevice.cpp +++ b/Kernel/Bus/USB/USBDevice.cpp @@ -51,9 +51,7 @@ Device::Device(Device const& device, NonnullOwnPtr default_pipe) { } -Device::~Device() -{ -} +Device::~Device() = default; ErrorOr Device::enumerate_device() { diff --git a/Kernel/Bus/USB/USBTransfer.cpp b/Kernel/Bus/USB/USBTransfer.cpp index e2eb744a2b..c01b3904e7 100644 --- a/Kernel/Bus/USB/USBTransfer.cpp +++ b/Kernel/Bus/USB/USBTransfer.cpp @@ -24,9 +24,7 @@ Transfer::Transfer(Pipe& pipe, u16 len, NonnullOwnPtr data_buffe { } -Transfer::~Transfer() -{ -} +Transfer::~Transfer() = default; void Transfer::set_setup_packet(const USBRequestData& request) { diff --git a/Kernel/Bus/VirtIO/Queue.cpp b/Kernel/Bus/VirtIO/Queue.cpp index 0263708170..cb31571e4a 100644 --- a/Kernel/Bus/VirtIO/Queue.cpp +++ b/Kernel/Bus/VirtIO/Queue.cpp @@ -44,9 +44,7 @@ Queue::Queue(NonnullOwnPtr queue_region, u16 queue_size, u16 not enable_interrupts(); } -Queue::~Queue() -{ -} +Queue::~Queue() = default; void Queue::enable_interrupts() { diff --git a/Kernel/Devices/Audio/AC97.cpp b/Kernel/Devices/Audio/AC97.cpp index 03aa09d585..7d2ced170e 100644 --- a/Kernel/Devices/Audio/AC97.cpp +++ b/Kernel/Devices/Audio/AC97.cpp @@ -36,9 +36,7 @@ UNMAP_AFTER_INIT AC97::AC97(PCI::DeviceIdentifier const& pci_device_identifier) { } -UNMAP_AFTER_INIT AC97::~AC97() -{ -} +UNMAP_AFTER_INIT AC97::~AC97() = default; bool AC97::handle_irq(RegisterState const&) { diff --git a/Kernel/Devices/Audio/Channel.h b/Kernel/Devices/Audio/Channel.h index 08da059352..affd85a8ff 100644 --- a/Kernel/Devices/Audio/Channel.h +++ b/Kernel/Devices/Audio/Channel.h @@ -21,7 +21,7 @@ class AudioChannel final public: static NonnullRefPtr must_create(AudioController const&, size_t channel_index); - virtual ~AudioChannel() override { } + virtual ~AudioChannel() override = default; // ^CharacterDevice virtual bool can_read(const OpenFileDescription&, u64) const override; diff --git a/Kernel/Devices/BlockDevice.cpp b/Kernel/Devices/BlockDevice.cpp index 2cf7a1ccd6..a9e8f2d802 100644 --- a/Kernel/Devices/BlockDevice.cpp +++ b/Kernel/Devices/BlockDevice.cpp @@ -24,9 +24,7 @@ void AsyncBlockDeviceRequest::start() m_block_device.start_request(*this); } -BlockDevice::~BlockDevice() -{ -} +BlockDevice::~BlockDevice() = default; bool BlockDevice::read_block(u64 index, UserOrKernelBuffer& buffer) { diff --git a/Kernel/Devices/CharacterDevice.cpp b/Kernel/Devices/CharacterDevice.cpp index b3688ad23c..e44a1433ac 100644 --- a/Kernel/Devices/CharacterDevice.cpp +++ b/Kernel/Devices/CharacterDevice.cpp @@ -8,8 +8,6 @@ namespace Kernel { -CharacterDevice::~CharacterDevice() -{ -} +CharacterDevice::~CharacterDevice() = default; } diff --git a/Kernel/Devices/ConsoleDevice.cpp b/Kernel/Devices/ConsoleDevice.cpp index e2cb009e10..5de75013af 100644 --- a/Kernel/Devices/ConsoleDevice.cpp +++ b/Kernel/Devices/ConsoleDevice.cpp @@ -28,9 +28,7 @@ UNMAP_AFTER_INIT ConsoleDevice::ConsoleDevice() { } -UNMAP_AFTER_INIT ConsoleDevice::~ConsoleDevice() -{ -} +UNMAP_AFTER_INIT ConsoleDevice::~ConsoleDevice() = default; bool ConsoleDevice::can_read(const Kernel::OpenFileDescription&, u64) const { diff --git a/Kernel/Devices/DeviceControlDevice.cpp b/Kernel/Devices/DeviceControlDevice.cpp index 28d36dd343..a78d03f40b 100644 --- a/Kernel/Devices/DeviceControlDevice.cpp +++ b/Kernel/Devices/DeviceControlDevice.cpp @@ -27,9 +27,7 @@ UNMAP_AFTER_INIT DeviceControlDevice::DeviceControlDevice() { } -UNMAP_AFTER_INIT DeviceControlDevice::~DeviceControlDevice() -{ -} +UNMAP_AFTER_INIT DeviceControlDevice::~DeviceControlDevice() = default; ErrorOr DeviceControlDevice::read(OpenFileDescription&, u64, UserOrKernelBuffer& buffer, size_t size) { diff --git a/Kernel/Devices/FullDevice.cpp b/Kernel/Devices/FullDevice.cpp index 98a91c5a3f..14cbaa817b 100644 --- a/Kernel/Devices/FullDevice.cpp +++ b/Kernel/Devices/FullDevice.cpp @@ -25,9 +25,7 @@ UNMAP_AFTER_INIT FullDevice::FullDevice() { } -UNMAP_AFTER_INIT FullDevice::~FullDevice() -{ -} +UNMAP_AFTER_INIT FullDevice::~FullDevice() = default; bool FullDevice::can_read(const OpenFileDescription&, u64) const { diff --git a/Kernel/Devices/HID/KeyboardDevice.cpp b/Kernel/Devices/HID/KeyboardDevice.cpp index 6b22a28d27..db88181837 100644 --- a/Kernel/Devices/HID/KeyboardDevice.cpp +++ b/Kernel/Devices/HID/KeyboardDevice.cpp @@ -276,9 +276,7 @@ UNMAP_AFTER_INIT KeyboardDevice::KeyboardDevice() // FIXME: UNMAP_AFTER_INIT is fine for now, but for hot-pluggable devices // like USB keyboards, we need to remove this -UNMAP_AFTER_INIT KeyboardDevice::~KeyboardDevice() -{ -} +UNMAP_AFTER_INIT KeyboardDevice::~KeyboardDevice() = default; bool KeyboardDevice::can_read(const OpenFileDescription&, u64) const { diff --git a/Kernel/Devices/HID/MouseDevice.cpp b/Kernel/Devices/HID/MouseDevice.cpp index 5139ec892d..1aff69396f 100644 --- a/Kernel/Devices/HID/MouseDevice.cpp +++ b/Kernel/Devices/HID/MouseDevice.cpp @@ -14,9 +14,7 @@ MouseDevice::MouseDevice() { } -MouseDevice::~MouseDevice() -{ -} +MouseDevice::~MouseDevice() = default; bool MouseDevice::can_read(const OpenFileDescription&, u64) const { diff --git a/Kernel/Devices/HID/PS2KeyboardDevice.cpp b/Kernel/Devices/HID/PS2KeyboardDevice.cpp index c492c9e621..3eeb1d37b4 100644 --- a/Kernel/Devices/HID/PS2KeyboardDevice.cpp +++ b/Kernel/Devices/HID/PS2KeyboardDevice.cpp @@ -116,8 +116,6 @@ UNMAP_AFTER_INIT PS2KeyboardDevice::PS2KeyboardDevice(const I8042Controller& ps2 // FIXME: UNMAP_AFTER_INIT might not be correct, because in practice PS/2 devices // are hot pluggable. -UNMAP_AFTER_INIT PS2KeyboardDevice::~PS2KeyboardDevice() -{ -} +UNMAP_AFTER_INIT PS2KeyboardDevice::~PS2KeyboardDevice() = default; } diff --git a/Kernel/Devices/HID/PS2MouseDevice.cpp b/Kernel/Devices/HID/PS2MouseDevice.cpp index 57b48c7e76..ed45d78034 100644 --- a/Kernel/Devices/HID/PS2MouseDevice.cpp +++ b/Kernel/Devices/HID/PS2MouseDevice.cpp @@ -26,9 +26,7 @@ UNMAP_AFTER_INIT PS2MouseDevice::PS2MouseDevice(const I8042Controller& ps2_contr { } -UNMAP_AFTER_INIT PS2MouseDevice::~PS2MouseDevice() -{ -} +UNMAP_AFTER_INIT PS2MouseDevice::~PS2MouseDevice() = default; bool PS2MouseDevice::handle_irq(const RegisterState&) { diff --git a/Kernel/Devices/HID/VMWareMouseDevice.cpp b/Kernel/Devices/HID/VMWareMouseDevice.cpp index a8c68ccbbd..2d143f983e 100644 --- a/Kernel/Devices/HID/VMWareMouseDevice.cpp +++ b/Kernel/Devices/HID/VMWareMouseDevice.cpp @@ -57,8 +57,6 @@ VMWareMouseDevice::VMWareMouseDevice(const I8042Controller& ps2_controller) : PS2MouseDevice(ps2_controller) { } -VMWareMouseDevice::~VMWareMouseDevice() -{ -} +VMWareMouseDevice::~VMWareMouseDevice() = default; } diff --git a/Kernel/Devices/MemoryDevice.cpp b/Kernel/Devices/MemoryDevice.cpp index 6396f07b5d..e22ea8565f 100644 --- a/Kernel/Devices/MemoryDevice.cpp +++ b/Kernel/Devices/MemoryDevice.cpp @@ -28,9 +28,7 @@ UNMAP_AFTER_INIT MemoryDevice::MemoryDevice() { } -UNMAP_AFTER_INIT MemoryDevice::~MemoryDevice() -{ -} +UNMAP_AFTER_INIT MemoryDevice::~MemoryDevice() = default; ErrorOr MemoryDevice::read(OpenFileDescription&, u64 offset, UserOrKernelBuffer& buffer, size_t length) { diff --git a/Kernel/Devices/NullDevice.cpp b/Kernel/Devices/NullDevice.cpp index b9cfc2cde5..4a30e9a09e 100644 --- a/Kernel/Devices/NullDevice.cpp +++ b/Kernel/Devices/NullDevice.cpp @@ -24,9 +24,7 @@ UNMAP_AFTER_INIT NullDevice::NullDevice() { } -UNMAP_AFTER_INIT NullDevice::~NullDevice() -{ -} +UNMAP_AFTER_INIT NullDevice::~NullDevice() = default; bool NullDevice::can_read(const OpenFileDescription&, u64) const { diff --git a/Kernel/Devices/RandomDevice.cpp b/Kernel/Devices/RandomDevice.cpp index d384313435..9734349d27 100644 --- a/Kernel/Devices/RandomDevice.cpp +++ b/Kernel/Devices/RandomDevice.cpp @@ -24,9 +24,7 @@ UNMAP_AFTER_INIT RandomDevice::RandomDevice() { } -UNMAP_AFTER_INIT RandomDevice::~RandomDevice() -{ -} +UNMAP_AFTER_INIT RandomDevice::~RandomDevice() = default; bool RandomDevice::can_read(const OpenFileDescription&, u64) const { diff --git a/Kernel/Devices/SerialDevice.cpp b/Kernel/Devices/SerialDevice.cpp index 65ed9fe49f..50d603e118 100644 --- a/Kernel/Devices/SerialDevice.cpp +++ b/Kernel/Devices/SerialDevice.cpp @@ -52,9 +52,7 @@ UNMAP_AFTER_INIT SerialDevice::SerialDevice(IOAddress base_addr, unsigned minor) initialize(); } -UNMAP_AFTER_INIT SerialDevice::~SerialDevice() -{ -} +UNMAP_AFTER_INIT SerialDevice::~SerialDevice() = default; bool SerialDevice::can_read(const OpenFileDescription&, u64) const { diff --git a/Kernel/Devices/ZeroDevice.cpp b/Kernel/Devices/ZeroDevice.cpp index 2024db5f74..1d001630cf 100644 --- a/Kernel/Devices/ZeroDevice.cpp +++ b/Kernel/Devices/ZeroDevice.cpp @@ -24,9 +24,7 @@ UNMAP_AFTER_INIT ZeroDevice::ZeroDevice() { } -UNMAP_AFTER_INIT ZeroDevice::~ZeroDevice() -{ -} +UNMAP_AFTER_INIT ZeroDevice::~ZeroDevice() = default; bool ZeroDevice::can_read(const OpenFileDescription&, u64) const { diff --git a/Kernel/FileSystem/AnonymousFile.cpp b/Kernel/FileSystem/AnonymousFile.cpp index b3e0a92b70..3e7955e972 100644 --- a/Kernel/FileSystem/AnonymousFile.cpp +++ b/Kernel/FileSystem/AnonymousFile.cpp @@ -15,9 +15,7 @@ AnonymousFile::AnonymousFile(NonnullRefPtr vmobject) { } -AnonymousFile::~AnonymousFile() -{ -} +AnonymousFile::~AnonymousFile() = default; ErrorOr AnonymousFile::mmap(Process& process, OpenFileDescription&, Memory::VirtualRange const& range, u64 offset, int prot, bool shared) { diff --git a/Kernel/FileSystem/BlockBasedFileSystem.cpp b/Kernel/FileSystem/BlockBasedFileSystem.cpp index 8e7bee709a..1325c12d48 100644 --- a/Kernel/FileSystem/BlockBasedFileSystem.cpp +++ b/Kernel/FileSystem/BlockBasedFileSystem.cpp @@ -114,9 +114,7 @@ BlockBasedFileSystem::BlockBasedFileSystem(OpenFileDescription& file_description VERIFY(file_description.file().is_seekable()); } -BlockBasedFileSystem::~BlockBasedFileSystem() -{ -} +BlockBasedFileSystem::~BlockBasedFileSystem() = default; ErrorOr BlockBasedFileSystem::initialize() { diff --git a/Kernel/FileSystem/Custody.cpp b/Kernel/FileSystem/Custody.cpp index 06e68fc183..f3944b793b 100644 --- a/Kernel/FileSystem/Custody.cpp +++ b/Kernel/FileSystem/Custody.cpp @@ -47,9 +47,7 @@ Custody::Custody(Custody* parent, NonnullOwnPtr name, Inode& inode, int { } -Custody::~Custody() -{ -} +Custody::~Custody() = default; ErrorOr> Custody::try_serialize_absolute_path() const { diff --git a/Kernel/FileSystem/DevPtsFS.cpp b/Kernel/FileSystem/DevPtsFS.cpp index 4eb8b0a541..d09a58862f 100644 --- a/Kernel/FileSystem/DevPtsFS.cpp +++ b/Kernel/FileSystem/DevPtsFS.cpp @@ -17,13 +17,8 @@ ErrorOr> DevPtsFS::try_create() return adopt_nonnull_ref_or_enomem(new (nothrow) DevPtsFS); } -DevPtsFS::DevPtsFS() -{ -} - -DevPtsFS::~DevPtsFS() -{ -} +DevPtsFS::DevPtsFS() = default; +DevPtsFS::~DevPtsFS() = default; ErrorOr DevPtsFS::initialize() { @@ -81,9 +76,7 @@ DevPtsFSInode::DevPtsFSInode(DevPtsFS& fs, InodeIndex index, SlavePTY* pty) m_pty = *pty; } -DevPtsFSInode::~DevPtsFSInode() -{ -} +DevPtsFSInode::~DevPtsFSInode() = default; ErrorOr DevPtsFSInode::read_bytes(off_t, size_t, UserOrKernelBuffer&, OpenFileDescription*) const { diff --git a/Kernel/FileSystem/DevTmpFS.cpp b/Kernel/FileSystem/DevTmpFS.cpp index 34736caf35..151bd6d12b 100644 --- a/Kernel/FileSystem/DevTmpFS.cpp +++ b/Kernel/FileSystem/DevTmpFS.cpp @@ -16,9 +16,7 @@ ErrorOr> DevTmpFS::try_create() return adopt_nonnull_ref_or_enomem(new (nothrow) DevTmpFS); } -DevTmpFS::DevTmpFS() -{ -} +DevTmpFS::DevTmpFS() = default; size_t DevTmpFS::allocate_inode_index() { @@ -28,9 +26,7 @@ size_t DevTmpFS::allocate_inode_index() return 1 + m_next_inode_index.value(); } -DevTmpFS::~DevTmpFS() -{ -} +DevTmpFS::~DevTmpFS() = default; ErrorOr DevTmpFS::initialize() { @@ -167,9 +163,7 @@ StringView DevTmpFSLinkInode::name() const return m_name->view(); } -DevTmpFSLinkInode::~DevTmpFSLinkInode() -{ -} +DevTmpFSLinkInode::~DevTmpFSLinkInode() = default; DevTmpFSLinkInode::DevTmpFSLinkInode(DevTmpFS& fs, NonnullOwnPtr name) : DevTmpFSInode(fs) @@ -206,9 +200,7 @@ DevTmpFSDirectoryInode::DevTmpFSDirectoryInode(DevTmpFS& fs, NonnullOwnPtr DevTmpFSDirectoryInode::traverse_as_directory(Function(FileSystem::DirectoryEntryView const&)> callback) const { @@ -286,9 +278,7 @@ DevTmpFSRootDirectoryInode::DevTmpFSRootDirectoryInode(DevTmpFS& fs) { m_mode = 0555; } -DevTmpFSRootDirectoryInode::~DevTmpFSRootDirectoryInode() -{ -} +DevTmpFSRootDirectoryInode::~DevTmpFSRootDirectoryInode() = default; ErrorOr DevTmpFSRootDirectoryInode::chmod(mode_t) { return EPERM; @@ -306,9 +296,7 @@ DevTmpFSDeviceInode::DevTmpFSDeviceInode(DevTmpFS& fs, MajorNumber major_number, { } -DevTmpFSDeviceInode::~DevTmpFSDeviceInode() -{ -} +DevTmpFSDeviceInode::~DevTmpFSDeviceInode() = default; StringView DevTmpFSDeviceInode::name() const { diff --git a/Kernel/FileSystem/Ext2FileSystem.cpp b/Kernel/FileSystem/Ext2FileSystem.cpp index 8d1e320ceb..27eb4766f0 100644 --- a/Kernel/FileSystem/Ext2FileSystem.cpp +++ b/Kernel/FileSystem/Ext2FileSystem.cpp @@ -59,9 +59,7 @@ Ext2FS::Ext2FS(OpenFileDescription& file_description) { } -Ext2FS::~Ext2FS() -{ -} +Ext2FS::~Ext2FS() = default; ErrorOr Ext2FS::flush_super_block() { diff --git a/Kernel/FileSystem/FIFO.cpp b/Kernel/FileSystem/FIFO.cpp index a4edad37d9..0d0e63df2c 100644 --- a/Kernel/FileSystem/FIFO.cpp +++ b/Kernel/FileSystem/FIFO.cpp @@ -71,9 +71,7 @@ FIFO::FIFO(UserID uid, NonnullOwnPtr buffer) }); } -FIFO::~FIFO() -{ -} +FIFO::~FIFO() = default; void FIFO::attach(Direction direction) { diff --git a/Kernel/FileSystem/File.cpp b/Kernel/FileSystem/File.cpp index 5b44450ce0..16873b3ec3 100644 --- a/Kernel/FileSystem/File.cpp +++ b/Kernel/FileSystem/File.cpp @@ -12,13 +12,8 @@ namespace Kernel { -File::File() -{ -} - -File::~File() -{ -} +File::File() = default; +File::~File() = default; ErrorOr> File::open(int options) { diff --git a/Kernel/FileSystem/FileBackedFileSystem.cpp b/Kernel/FileSystem/FileBackedFileSystem.cpp index 44ee0a70ff..ab0c1e97e4 100644 --- a/Kernel/FileSystem/FileBackedFileSystem.cpp +++ b/Kernel/FileSystem/FileBackedFileSystem.cpp @@ -13,8 +13,6 @@ FileBackedFileSystem::FileBackedFileSystem(OpenFileDescription& file_description { } -FileBackedFileSystem::~FileBackedFileSystem() -{ -} +FileBackedFileSystem::~FileBackedFileSystem() = default; } diff --git a/Kernel/FileSystem/ISO9660FileSystem.cpp b/Kernel/FileSystem/ISO9660FileSystem.cpp index 316209e6de..ed688363ac 100644 --- a/Kernel/FileSystem/ISO9660FileSystem.cpp +++ b/Kernel/FileSystem/ISO9660FileSystem.cpp @@ -180,9 +180,7 @@ ISO9660FS::ISO9660FS(OpenFileDescription& description) m_logical_block_size = logical_sector_size; } -ISO9660FS::~ISO9660FS() -{ -} +ISO9660FS::~ISO9660FS() = default; ErrorOr ISO9660FS::initialize() { @@ -553,9 +551,7 @@ ISO9660Inode::ISO9660Inode(ISO9660FS& fs, ISO::DirectoryRecordHeader const& reco create_metadata(); } -ISO9660Inode::~ISO9660Inode() -{ -} +ISO9660Inode::~ISO9660Inode() = default; ErrorOr> ISO9660Inode::try_create_from_directory_record(ISO9660FS& fs, ISO::DirectoryRecordHeader const& record, StringView name) { diff --git a/Kernel/FileSystem/InodeFile.cpp b/Kernel/FileSystem/InodeFile.cpp index 6ee7a5ac8e..eeccf5fcae 100644 --- a/Kernel/FileSystem/InodeFile.cpp +++ b/Kernel/FileSystem/InodeFile.cpp @@ -22,9 +22,7 @@ InodeFile::InodeFile(NonnullRefPtr&& inode) { } -InodeFile::~InodeFile() -{ -} +InodeFile::~InodeFile() = default; ErrorOr InodeFile::read(OpenFileDescription& description, u64 offset, UserOrKernelBuffer& buffer, size_t count) { diff --git a/Kernel/FileSystem/Plan9FileSystem.cpp b/Kernel/FileSystem/Plan9FileSystem.cpp index 5f447198b7..a4f34c3437 100644 --- a/Kernel/FileSystem/Plan9FileSystem.cpp +++ b/Kernel/FileSystem/Plan9FileSystem.cpp @@ -399,9 +399,7 @@ Plan9FS::ReceiveCompletion::ReceiveCompletion(u16 tag) { } -Plan9FS::ReceiveCompletion::~ReceiveCompletion() -{ -} +Plan9FS::ReceiveCompletion::~ReceiveCompletion() = default; bool Plan9FS::Blocker::unblock(u16 tag) { diff --git a/Kernel/FileSystem/ProcFS.cpp b/Kernel/FileSystem/ProcFS.cpp index 6b2f0715ff..01e25b758b 100644 --- a/Kernel/FileSystem/ProcFS.cpp +++ b/Kernel/FileSystem/ProcFS.cpp @@ -42,13 +42,8 @@ ErrorOr> ProcFS::try_create() return adopt_nonnull_ref_or_enomem(new (nothrow) ProcFS()); } -ProcFS::ProcFS() -{ -} - -ProcFS::~ProcFS() -{ -} +ProcFS::ProcFS() = default; +ProcFS::~ProcFS() = default; ErrorOr ProcFS::initialize() { @@ -66,9 +61,7 @@ ProcFSInode::ProcFSInode(const ProcFS& fs, InodeIndex index) { } -ProcFSInode::~ProcFSInode() -{ -} +ProcFSInode::~ProcFSInode() = default; ErrorOr ProcFSInode::flush_metadata() { @@ -185,9 +178,7 @@ ProcFSDirectoryInode::ProcFSDirectoryInode(const ProcFS& fs, const ProcFSExposed { } -ProcFSDirectoryInode::~ProcFSDirectoryInode() -{ -} +ProcFSDirectoryInode::~ProcFSDirectoryInode() = default; InodeMetadata ProcFSDirectoryInode::metadata() const { MutexLocker locker(m_inode_lock); diff --git a/Kernel/FileSystem/SysFS.cpp b/Kernel/FileSystem/SysFS.cpp index 7395f0addb..d3ac479ffb 100644 --- a/Kernel/FileSystem/SysFS.cpp +++ b/Kernel/FileSystem/SysFS.cpp @@ -73,13 +73,8 @@ ErrorOr> SysFS::try_create() return adopt_nonnull_ref_or_enomem(new (nothrow) SysFS); } -SysFS::SysFS() -{ -} - -SysFS::~SysFS() -{ -} +SysFS::SysFS() = default; +SysFS::~SysFS() = default; ErrorOr SysFS::initialize() { @@ -202,9 +197,7 @@ SysFSDirectoryInode::SysFSDirectoryInode(SysFS const& fs, SysFSComponent const& { } -SysFSDirectoryInode::~SysFSDirectoryInode() -{ -} +SysFSDirectoryInode::~SysFSDirectoryInode() = default; InodeMetadata SysFSDirectoryInode::metadata() const { diff --git a/Kernel/FileSystem/TmpFS.cpp b/Kernel/FileSystem/TmpFS.cpp index aac29ad936..0b44c20d68 100644 --- a/Kernel/FileSystem/TmpFS.cpp +++ b/Kernel/FileSystem/TmpFS.cpp @@ -15,13 +15,8 @@ ErrorOr> TmpFS::try_create() return adopt_nonnull_ref_or_enomem(new (nothrow) TmpFS); } -TmpFS::TmpFS() -{ -} - -TmpFS::~TmpFS() -{ -} +TmpFS::TmpFS() = default; +TmpFS::~TmpFS() = default; ErrorOr TmpFS::initialize() { @@ -50,9 +45,7 @@ TmpFSInode::TmpFSInode(TmpFS& fs, const InodeMetadata& metadata, WeakPtr> TmpFSInode::try_create(TmpFS& fs, InodeMetadata const& metadata, WeakPtr parent) { diff --git a/Kernel/FileSystem/VirtualFileSystem.cpp b/Kernel/FileSystem/VirtualFileSystem.cpp index 46a9c6209c..e2c464a86d 100644 --- a/Kernel/FileSystem/VirtualFileSystem.cpp +++ b/Kernel/FileSystem/VirtualFileSystem.cpp @@ -40,9 +40,7 @@ UNMAP_AFTER_INIT VirtualFileSystem::VirtualFileSystem() { } -UNMAP_AFTER_INIT VirtualFileSystem::~VirtualFileSystem() -{ -} +UNMAP_AFTER_INIT VirtualFileSystem::~VirtualFileSystem() = default; InodeIdentifier VirtualFileSystem::root_inode_id() const { diff --git a/Kernel/FutexQueue.cpp b/Kernel/FutexQueue.cpp index de94f0dc94..6445c93a32 100644 --- a/Kernel/FutexQueue.cpp +++ b/Kernel/FutexQueue.cpp @@ -10,13 +10,8 @@ namespace Kernel { -FutexQueue::FutexQueue() -{ -} - -FutexQueue::~FutexQueue() -{ -} +FutexQueue::FutexQueue() = default; +FutexQueue::~FutexQueue() = default; bool FutexQueue::should_add_blocker(Thread::Blocker& b, void*) { diff --git a/Kernel/GlobalProcessExposed.cpp b/Kernel/GlobalProcessExposed.cpp index a4c68ca489..023df020f7 100644 --- a/Kernel/GlobalProcessExposed.cpp +++ b/Kernel/GlobalProcessExposed.cpp @@ -1032,8 +1032,6 @@ UNMAP_AFTER_INIT ProcFSRootDirectory::ProcFSRootDirectory() { } -UNMAP_AFTER_INIT ProcFSRootDirectory::~ProcFSRootDirectory() -{ -} +UNMAP_AFTER_INIT ProcFSRootDirectory::~ProcFSRootDirectory() = default; } diff --git a/Kernel/Graphics/Console/Console.h b/Kernel/Graphics/Console/Console.h index 028b69046d..ef10643b8f 100644 --- a/Kernel/Graphics/Console/Console.h +++ b/Kernel/Graphics/Console/Console.h @@ -59,7 +59,7 @@ public: virtual void write(char ch, bool critical = false) = 0; virtual void flush(size_t x, size_t y, size_t width, size_t height) = 0; - virtual ~Console() { } + virtual ~Console() = default; protected: Console(size_t width, size_t height) diff --git a/Kernel/Graphics/VirtIOGPU/FramebufferDevice.cpp b/Kernel/Graphics/VirtIOGPU/FramebufferDevice.cpp index 74c4bef463..8a0de5ca66 100644 --- a/Kernel/Graphics/VirtIOGPU/FramebufferDevice.cpp +++ b/Kernel/Graphics/VirtIOGPU/FramebufferDevice.cpp @@ -159,9 +159,7 @@ FramebufferDevice::FramebufferDevice(GraphicsAdapter const& adapter, ScanoutID s } } -FramebufferDevice::~FramebufferDevice() -{ -} +FramebufferDevice::~FramebufferDevice() = default; ErrorOr FramebufferDevice::create_framebuffer() { diff --git a/Kernel/Interrupts/IRQHandler.cpp b/Kernel/Interrupts/IRQHandler.cpp index ccc58dd5e8..d73ccc94cd 100644 --- a/Kernel/Interrupts/IRQHandler.cpp +++ b/Kernel/Interrupts/IRQHandler.cpp @@ -19,9 +19,7 @@ IRQHandler::IRQHandler(u8 irq) disable_irq(); } -IRQHandler::~IRQHandler() -{ -} +IRQHandler::~IRQHandler() = default; bool IRQHandler::eoi() { diff --git a/Kernel/Interrupts/SpuriousInterruptHandler.cpp b/Kernel/Interrupts/SpuriousInterruptHandler.cpp index b43f9fa574..0b2d3adbe8 100644 --- a/Kernel/Interrupts/SpuriousInterruptHandler.cpp +++ b/Kernel/Interrupts/SpuriousInterruptHandler.cpp @@ -67,9 +67,7 @@ SpuriousInterruptHandler::SpuriousInterruptHandler(u8 irq) { } -SpuriousInterruptHandler::~SpuriousInterruptHandler() -{ -} +SpuriousInterruptHandler::~SpuriousInterruptHandler() = default; bool SpuriousInterruptHandler::handle_interrupt(const RegisterState& state) { diff --git a/Kernel/Interrupts/UnhandledInterruptHandler.cpp b/Kernel/Interrupts/UnhandledInterruptHandler.cpp index b899a52237..ee46a493c3 100644 --- a/Kernel/Interrupts/UnhandledInterruptHandler.cpp +++ b/Kernel/Interrupts/UnhandledInterruptHandler.cpp @@ -23,7 +23,5 @@ bool UnhandledInterruptHandler::handle_interrupt(const RegisterState&) PANIC("Interrupt: Unhandled vector {} was invoked for eoi().", interrupt_number()); } -UnhandledInterruptHandler::~UnhandledInterruptHandler() -{ -} +UnhandledInterruptHandler::~UnhandledInterruptHandler() = default; } diff --git a/Kernel/Memory/AddressSpace.cpp b/Kernel/Memory/AddressSpace.cpp index f976bb6a8b..d5fdd97e05 100644 --- a/Kernel/Memory/AddressSpace.cpp +++ b/Kernel/Memory/AddressSpace.cpp @@ -29,9 +29,7 @@ AddressSpace::AddressSpace(NonnullRefPtr page_directory) { } -AddressSpace::~AddressSpace() -{ -} +AddressSpace::~AddressSpace() = default; ErrorOr AddressSpace::unmap_mmap_range(VirtualAddress addr, size_t size) { diff --git a/Kernel/Memory/AnonymousVMObject.cpp b/Kernel/Memory/AnonymousVMObject.cpp index 1625c677e8..43b0c7cd64 100644 --- a/Kernel/Memory/AnonymousVMObject.cpp +++ b/Kernel/Memory/AnonymousVMObject.cpp @@ -166,9 +166,7 @@ AnonymousVMObject::AnonymousVMObject(AnonymousVMObject const& other, NonnullRefP { } -AnonymousVMObject::~AnonymousVMObject() -{ -} +AnonymousVMObject::~AnonymousVMObject() = default; size_t AnonymousVMObject::purge() { @@ -370,9 +368,7 @@ AnonymousVMObject::SharedCommittedCowPages::SharedCommittedCowPages(CommittedPhy { } -AnonymousVMObject::SharedCommittedCowPages::~SharedCommittedCowPages() -{ -} +AnonymousVMObject::SharedCommittedCowPages::~SharedCommittedCowPages() = default; NonnullRefPtr AnonymousVMObject::SharedCommittedCowPages::take_one() { diff --git a/Kernel/Memory/InodeVMObject.cpp b/Kernel/Memory/InodeVMObject.cpp index a072968d85..77cacf7e53 100644 --- a/Kernel/Memory/InodeVMObject.cpp +++ b/Kernel/Memory/InodeVMObject.cpp @@ -25,9 +25,7 @@ InodeVMObject::InodeVMObject(InodeVMObject const& other, FixedArray> PageDirectory::try_create_for_userspace(Vi return directory; } -PageDirectory::PageDirectory() -{ -} +PageDirectory::PageDirectory() = default; UNMAP_AFTER_INIT void PageDirectory::allocate_kernel_directory() { diff --git a/Kernel/Memory/PhysicalRegion.cpp b/Kernel/Memory/PhysicalRegion.cpp index 9c4edfbed8..7f7409ee98 100644 --- a/Kernel/Memory/PhysicalRegion.cpp +++ b/Kernel/Memory/PhysicalRegion.cpp @@ -27,9 +27,7 @@ static constexpr u32 next_power_of_two(u32 value) return value; } -PhysicalRegion::~PhysicalRegion() -{ -} +PhysicalRegion::~PhysicalRegion() = default; PhysicalRegion::PhysicalRegion(PhysicalAddress lower, PhysicalAddress upper) : m_lower(lower) diff --git a/Kernel/Memory/PrivateInodeVMObject.cpp b/Kernel/Memory/PrivateInodeVMObject.cpp index 623e02776f..249a9eb8ea 100644 --- a/Kernel/Memory/PrivateInodeVMObject.cpp +++ b/Kernel/Memory/PrivateInodeVMObject.cpp @@ -33,8 +33,6 @@ PrivateInodeVMObject::PrivateInodeVMObject(PrivateInodeVMObject const& other, Fi { } -PrivateInodeVMObject::~PrivateInodeVMObject() -{ -} +PrivateInodeVMObject::~PrivateInodeVMObject() = default; } diff --git a/Kernel/Net/Intel/E1000ENetworkAdapter.cpp b/Kernel/Net/Intel/E1000ENetworkAdapter.cpp index f18fdfb642..82726a9af1 100644 --- a/Kernel/Net/Intel/E1000ENetworkAdapter.cpp +++ b/Kernel/Net/Intel/E1000ENetworkAdapter.cpp @@ -238,9 +238,7 @@ UNMAP_AFTER_INIT E1000ENetworkAdapter::E1000ENetworkAdapter(PCI::Address address { } -UNMAP_AFTER_INIT E1000ENetworkAdapter::~E1000ENetworkAdapter() -{ -} +UNMAP_AFTER_INIT E1000ENetworkAdapter::~E1000ENetworkAdapter() = default; UNMAP_AFTER_INIT void E1000ENetworkAdapter::detect_eeprom() { diff --git a/Kernel/Net/Intel/E1000NetworkAdapter.cpp b/Kernel/Net/Intel/E1000NetworkAdapter.cpp index 5fc6ec6d86..2c4b04af4e 100644 --- a/Kernel/Net/Intel/E1000NetworkAdapter.cpp +++ b/Kernel/Net/Intel/E1000NetworkAdapter.cpp @@ -236,9 +236,7 @@ UNMAP_AFTER_INIT E1000NetworkAdapter::E1000NetworkAdapter(PCI::Address address, { } -UNMAP_AFTER_INIT E1000NetworkAdapter::~E1000NetworkAdapter() -{ -} +UNMAP_AFTER_INIT E1000NetworkAdapter::~E1000NetworkAdapter() = default; bool E1000NetworkAdapter::handle_irq(const RegisterState&) { diff --git a/Kernel/Net/LoopbackAdapter.cpp b/Kernel/Net/LoopbackAdapter.cpp index b0027ca6d9..c3e517a297 100644 --- a/Kernel/Net/LoopbackAdapter.cpp +++ b/Kernel/Net/LoopbackAdapter.cpp @@ -28,9 +28,7 @@ LoopbackAdapter::LoopbackAdapter(NonnullOwnPtr interface_name) set_mac_address({ 19, 85, 2, 9, 0x55, 0xaa }); } -LoopbackAdapter::~LoopbackAdapter() -{ -} +LoopbackAdapter::~LoopbackAdapter() = default; void LoopbackAdapter::send_raw(ReadonlyBytes payload) { diff --git a/Kernel/Net/NE2000/NetworkAdapter.cpp b/Kernel/Net/NE2000/NetworkAdapter.cpp index b22622a809..83146b9484 100644 --- a/Kernel/Net/NE2000/NetworkAdapter.cpp +++ b/Kernel/Net/NE2000/NetworkAdapter.cpp @@ -185,9 +185,7 @@ UNMAP_AFTER_INIT NE2000NetworkAdapter::NE2000NetworkAdapter(PCI::Address address enable_irq(); } -UNMAP_AFTER_INIT NE2000NetworkAdapter::~NE2000NetworkAdapter() -{ -} +UNMAP_AFTER_INIT NE2000NetworkAdapter::~NE2000NetworkAdapter() = default; bool NE2000NetworkAdapter::handle_irq(const RegisterState&) { diff --git a/Kernel/Net/NetworkAdapter.cpp b/Kernel/Net/NetworkAdapter.cpp index 13afd672d3..d471878bee 100644 --- a/Kernel/Net/NetworkAdapter.cpp +++ b/Kernel/Net/NetworkAdapter.cpp @@ -19,9 +19,7 @@ NetworkAdapter::NetworkAdapter(NonnullOwnPtr interface_name) { } -NetworkAdapter::~NetworkAdapter() -{ -} +NetworkAdapter::~NetworkAdapter() = default; void NetworkAdapter::send_packet(ReadonlyBytes packet) { diff --git a/Kernel/Net/Realtek/RTL8139NetworkAdapter.cpp b/Kernel/Net/Realtek/RTL8139NetworkAdapter.cpp index 832c3d9c60..2b00bf52b5 100644 --- a/Kernel/Net/Realtek/RTL8139NetworkAdapter.cpp +++ b/Kernel/Net/Realtek/RTL8139NetworkAdapter.cpp @@ -162,9 +162,7 @@ UNMAP_AFTER_INIT RTL8139NetworkAdapter::RTL8139NetworkAdapter(PCI::Address addre enable_irq(); } -UNMAP_AFTER_INIT RTL8139NetworkAdapter::~RTL8139NetworkAdapter() -{ -} +UNMAP_AFTER_INIT RTL8139NetworkAdapter::~RTL8139NetworkAdapter() = default; bool RTL8139NetworkAdapter::handle_irq(const RegisterState&) { diff --git a/Kernel/Net/Realtek/RTL8168NetworkAdapter.cpp b/Kernel/Net/Realtek/RTL8168NetworkAdapter.cpp index 5cebee86a4..5ddc016dcd 100644 --- a/Kernel/Net/Realtek/RTL8168NetworkAdapter.cpp +++ b/Kernel/Net/Realtek/RTL8168NetworkAdapter.cpp @@ -1125,9 +1125,7 @@ UNMAP_AFTER_INIT void RTL8168NetworkAdapter::initialize_tx_descriptors() tx_descriptors[number_of_tx_descriptors - 1].flags = tx_descriptors[number_of_tx_descriptors - 1].flags | TXDescriptor::EndOfRing; } -UNMAP_AFTER_INIT RTL8168NetworkAdapter::~RTL8168NetworkAdapter() -{ -} +UNMAP_AFTER_INIT RTL8168NetworkAdapter::~RTL8168NetworkAdapter() = default; bool RTL8168NetworkAdapter::handle_irq(const RegisterState&) { diff --git a/Kernel/Net/Socket.cpp b/Kernel/Net/Socket.cpp index 5080d089de..77654ef8ac 100644 --- a/Kernel/Net/Socket.cpp +++ b/Kernel/Net/Socket.cpp @@ -37,9 +37,7 @@ Socket::Socket(int domain, int type, int protocol) set_origin(Process::current()); } -Socket::~Socket() -{ -} +Socket::~Socket() = default; void Socket::set_setup_state(SetupState new_setup_state) { diff --git a/Kernel/ProcessExposed.cpp b/Kernel/ProcessExposed.cpp index 93ec0a998d..59824d4768 100644 --- a/Kernel/ProcessExposed.cpp +++ b/Kernel/ProcessExposed.cpp @@ -79,9 +79,7 @@ static size_t s_allocate_global_inode_index() return s_next_inode_index.value(); } -ProcFSExposedComponent::ProcFSExposedComponent() -{ -} +ProcFSExposedComponent::ProcFSExposedComponent() = default; ProcFSExposedComponent::ProcFSExposedComponent(StringView name) : m_component_index(s_allocate_global_inode_index()) diff --git a/Kernel/Storage/ATA/AHCIController.cpp b/Kernel/Storage/ATA/AHCIController.cpp index 940f89a200..b505f40f5b 100644 --- a/Kernel/Storage/ATA/AHCIController.cpp +++ b/Kernel/Storage/ATA/AHCIController.cpp @@ -135,9 +135,7 @@ NonnullOwnPtr AHCIController::default_hba_region() const return MM.allocate_kernel_region(PhysicalAddress(PCI::get_BAR5(pci_address())).page_base(), Memory::page_round_up(sizeof(AHCI::HBA)).release_value_but_fixme_should_propagate_errors(), "AHCI HBA", Memory::Region::Access::ReadWrite).release_value(); } -AHCIController::~AHCIController() -{ -} +AHCIController::~AHCIController() = default; void AHCIController::initialize_hba(PCI::DeviceIdentifier const& pci_device_identifier) { diff --git a/Kernel/Storage/ATA/AHCIPortHandler.cpp b/Kernel/Storage/ATA/AHCIPortHandler.cpp index 0d6d81c3d7..b009547767 100644 --- a/Kernel/Storage/ATA/AHCIPortHandler.cpp +++ b/Kernel/Storage/ATA/AHCIPortHandler.cpp @@ -78,9 +78,7 @@ AHCI::HBADefinedCapabilities AHCIPortHandler::hba_capabilities() const return m_parent_controller->hba_capabilities(); } -AHCIPortHandler::~AHCIPortHandler() -{ -} +AHCIPortHandler::~AHCIPortHandler() = default; bool AHCIPortHandler::handle_irq(const RegisterState&) { diff --git a/Kernel/Storage/ATA/ATADevice.cpp b/Kernel/Storage/ATA/ATADevice.cpp index c40f5b4eec..d4591affe1 100644 --- a/Kernel/Storage/ATA/ATADevice.cpp +++ b/Kernel/Storage/ATA/ATADevice.cpp @@ -21,9 +21,7 @@ ATADevice::ATADevice(const ATAController& controller, ATADevice::Address ata_add { } -ATADevice::~ATADevice() -{ -} +ATADevice::~ATADevice() = default; void ATADevice::start_request(AsyncBlockDeviceRequest& request) { diff --git a/Kernel/Storage/ATA/ATADiskDevice.cpp b/Kernel/Storage/ATA/ATADiskDevice.cpp index dd2f484661..4d2687725f 100644 --- a/Kernel/Storage/ATA/ATADiskDevice.cpp +++ b/Kernel/Storage/ATA/ATADiskDevice.cpp @@ -31,9 +31,7 @@ ATADiskDevice::ATADiskDevice(const ATAController& controller, ATADevice::Address { } -ATADiskDevice::~ATADiskDevice() -{ -} +ATADiskDevice::~ATADiskDevice() = default; StringView ATADiskDevice::class_name() const { diff --git a/Kernel/Storage/ATA/ATAPIDiscDevice.cpp b/Kernel/Storage/ATA/ATAPIDiscDevice.cpp index a9f7a91447..f7ea93f4b6 100644 --- a/Kernel/Storage/ATA/ATAPIDiscDevice.cpp +++ b/Kernel/Storage/ATA/ATAPIDiscDevice.cpp @@ -31,9 +31,7 @@ ATAPIDiscDevice::ATAPIDiscDevice(const ATAController& controller, ATADevice::Add { } -ATAPIDiscDevice::~ATAPIDiscDevice() -{ -} +ATAPIDiscDevice::~ATAPIDiscDevice() = default; StringView ATAPIDiscDevice::class_name() const { diff --git a/Kernel/Storage/ATA/IDEChannel.cpp b/Kernel/Storage/ATA/IDEChannel.cpp index fb4acf492f..f3ffdae92c 100644 --- a/Kernel/Storage/ATA/IDEChannel.cpp +++ b/Kernel/Storage/ATA/IDEChannel.cpp @@ -100,9 +100,7 @@ void IDEChannel::clear_pending_interrupts() const m_io_group.io_base().offset(ATA_REG_STATUS).in(); } -UNMAP_AFTER_INIT IDEChannel::~IDEChannel() -{ -} +UNMAP_AFTER_INIT IDEChannel::~IDEChannel() = default; void IDEChannel::start_request(AsyncBlockDeviceRequest& request, bool is_slave, u16 capabilities) { diff --git a/Kernel/Storage/ATA/IDEController.cpp b/Kernel/Storage/ATA/IDEController.cpp index 78fcb5fad8..52b71c4462 100644 --- a/Kernel/Storage/ATA/IDEController.cpp +++ b/Kernel/Storage/ATA/IDEController.cpp @@ -65,9 +65,7 @@ UNMAP_AFTER_INIT IDEController::IDEController() { } -UNMAP_AFTER_INIT IDEController::~IDEController() -{ -} +UNMAP_AFTER_INIT IDEController::~IDEController() = default; RefPtr IDEController::device_by_channel_and_position(u32 index) const { diff --git a/Kernel/Storage/NVMe/NVMeQueue.cpp b/Kernel/Storage/NVMe/NVMeQueue.cpp index bf531f9224..cde68a0c9d 100644 --- a/Kernel/Storage/NVMe/NVMeQueue.cpp +++ b/Kernel/Storage/NVMe/NVMeQueue.cpp @@ -172,7 +172,5 @@ void NVMeQueue::write(AsyncBlockDeviceRequest& request, u16 nsid, u64 index, u32 submit_sqe(sub); } -UNMAP_AFTER_INIT NVMeQueue::~NVMeQueue() -{ -} +UNMAP_AFTER_INIT NVMeQueue::~NVMeQueue() = default; } diff --git a/Kernel/Storage/Partition/DiskPartition.cpp b/Kernel/Storage/Partition/DiskPartition.cpp index 88ee937117..ba208e5980 100644 --- a/Kernel/Storage/Partition/DiskPartition.cpp +++ b/Kernel/Storage/Partition/DiskPartition.cpp @@ -26,9 +26,7 @@ DiskPartition::DiskPartition(BlockDevice& device, unsigned minor_number, DiskPar { } -DiskPartition::~DiskPartition() -{ -} +DiskPartition::~DiskPartition() = default; const DiskPartitionMetadata& DiskPartition::metadata() const { diff --git a/Kernel/Storage/Partition/EBRPartitionTable.cpp b/Kernel/Storage/Partition/EBRPartitionTable.cpp index 2d1bdbb895..8d2eefbcec 100644 --- a/Kernel/Storage/Partition/EBRPartitionTable.cpp +++ b/Kernel/Storage/Partition/EBRPartitionTable.cpp @@ -68,8 +68,6 @@ EBRPartitionTable::EBRPartitionTable(const StorageDevice& device) } } -EBRPartitionTable::~EBRPartitionTable() -{ -} +EBRPartitionTable::~EBRPartitionTable() = default; } diff --git a/Kernel/Storage/Partition/MBRPartitionTable.cpp b/Kernel/Storage/Partition/MBRPartitionTable.cpp index 0c11cf7a70..d5931e7c56 100644 --- a/Kernel/Storage/Partition/MBRPartitionTable.cpp +++ b/Kernel/Storage/Partition/MBRPartitionTable.cpp @@ -84,9 +84,7 @@ MBRPartitionTable::MBRPartitionTable(const StorageDevice& device) m_valid = true; } -MBRPartitionTable::~MBRPartitionTable() -{ -} +MBRPartitionTable::~MBRPartitionTable() = default; const MBRPartitionTable::Header& MBRPartitionTable::header() const { diff --git a/Kernel/Storage/RamdiskController.cpp b/Kernel/Storage/RamdiskController.cpp index a0d0a1df95..d70eadabb2 100644 --- a/Kernel/Storage/RamdiskController.cpp +++ b/Kernel/Storage/RamdiskController.cpp @@ -55,9 +55,7 @@ RamdiskController::RamdiskController() } } -RamdiskController::~RamdiskController() -{ -} +RamdiskController::~RamdiskController() = default; RefPtr RamdiskController::device(u32 index) const { diff --git a/Kernel/Storage/RamdiskDevice.cpp b/Kernel/Storage/RamdiskDevice.cpp index 2b3bda9240..d726d1879f 100644 --- a/Kernel/Storage/RamdiskDevice.cpp +++ b/Kernel/Storage/RamdiskDevice.cpp @@ -32,9 +32,7 @@ RamdiskDevice::RamdiskDevice(const RamdiskController&, NonnullOwnPtrvaddr(), max_addressable_block() * 512); } -RamdiskDevice::~RamdiskDevice() -{ -} +RamdiskDevice::~RamdiskDevice() = default; StringView RamdiskDevice::class_name() const { diff --git a/Kernel/TTY/PTYMultiplexer.cpp b/Kernel/TTY/PTYMultiplexer.cpp index ba6b46d103..4e64577cce 100644 --- a/Kernel/TTY/PTYMultiplexer.cpp +++ b/Kernel/TTY/PTYMultiplexer.cpp @@ -31,9 +31,7 @@ UNMAP_AFTER_INIT PTYMultiplexer::PTYMultiplexer() }); } -UNMAP_AFTER_INIT PTYMultiplexer::~PTYMultiplexer() -{ -} +UNMAP_AFTER_INIT PTYMultiplexer::~PTYMultiplexer() = default; UNMAP_AFTER_INIT void PTYMultiplexer::initialize() { diff --git a/Kernel/TTY/TTY.cpp b/Kernel/TTY/TTY.cpp index 1a09cfaa37..5a98100c87 100644 --- a/Kernel/TTY/TTY.cpp +++ b/Kernel/TTY/TTY.cpp @@ -26,9 +26,7 @@ TTY::TTY(MajorNumber major, MinorNumber minor) set_default_termios(); } -TTY::~TTY() -{ -} +TTY::~TTY() = default; void TTY::set_default_termios() { diff --git a/Kernel/ThreadBlockers.cpp b/Kernel/ThreadBlockers.cpp index 5a5dc51d73..c24d0aae9f 100644 --- a/Kernel/ThreadBlockers.cpp +++ b/Kernel/ThreadBlockers.cpp @@ -37,9 +37,7 @@ bool Thread::Blocker::add_to_blocker_set(Thread::BlockerSet& blocker_set, void* return false; } -Thread::Blocker::~Blocker() -{ -} +Thread::Blocker::~Blocker() = default; void Thread::Blocker::finalize() { @@ -132,9 +130,7 @@ bool Thread::WaitQueueBlocker::setup_blocker() return add_to_blocker_set(m_wait_queue); } -Thread::WaitQueueBlocker::~WaitQueueBlocker() -{ -} +Thread::WaitQueueBlocker::~WaitQueueBlocker() = default; bool Thread::WaitQueueBlocker::unblock() { @@ -160,9 +156,7 @@ bool Thread::FutexBlocker::setup_blocker() return add_to_blocker_set(m_futex_queue); } -Thread::FutexBlocker::~FutexBlocker() -{ -} +Thread::FutexBlocker::~FutexBlocker() = default; void Thread::FutexBlocker::finish_requeue(FutexQueue& futex_queue) { @@ -372,9 +366,7 @@ bool Thread::SelectBlocker::setup_blocker() return should_block; } -Thread::SelectBlocker::~SelectBlocker() -{ -} +Thread::SelectBlocker::~SelectBlocker() = default; void Thread::SelectBlocker::finalize() { @@ -504,9 +496,7 @@ Thread::WaitBlockerSet::ProcessBlockInfo::ProcessBlockInfo(NonnullRefPtr