RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 08:07:45 +00:00
Code Issues Activity Actions

LibWeb: Make factory method of HTML::WorkerNavigator fallible

Browse source
This commit is contained in:
Kenneth Myhra 2023-02-15 19:27:35 +01:00 • committed by Linus Groh
parent 86b7f148b9
commit 193de231e0
3 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/HTML/WorkerGlobalScope.cpp
View file

@ -10,6 +10,7 @@
#include <AK/Vector.h> #include <AK/Vector.h>
#include <LibJS/Runtime/Completion.h> #include <LibJS/Runtime/Completion.h>
#include <LibTextCodec/Decoder.h> #include <LibTextCodec/Decoder.h>
#include <LibWeb/Bindings/ExceptionOrUtils.h>
#include <LibWeb/Bindings/WorkerGlobalScopePrototype.h> #include <LibWeb/Bindings/WorkerGlobalScopePrototype.h>
#include <LibWeb/Forward.h> #include <LibWeb/Forward.h>
#include <LibWeb/HTML/EventHandler.h> #include <LibWeb/HTML/EventHandler.h>
@ -33,7 +34,9 @@ WorkerGlobalScope::~WorkerGlobalScope() = default;
JS::ThrowCompletionOr<void> WorkerGlobalScope::initialize(JS::Realm& realm) JS::ThrowCompletionOr<void> WorkerGlobalScope::initialize(JS::Realm& realm)
{ {
MUST_OR_THROW_OOM(Base::initialize(realm)); MUST_OR_THROW_OOM(Base::initialize(realm));
m_navigator = WorkerNavigator::create(*this); m_navigator = TRY(Bindings::throw_dom_exception_if_needed(realm.vm(), [&]() {
return WorkerNavigator::create(*this);
}));
return {}; return {};
} }

4
Userland/Libraries/LibWeb/HTML/WorkerNavigator.cpp
View file

@ -11,9 +11,9 @@
namespace Web::HTML { namespace Web::HTML {
JS::NonnullGCPtr<WorkerNavigator> WorkerNavigator::create(WorkerGlobalScope& global_scope) WebIDL::ExceptionOr<JS::NonnullGCPtr<WorkerNavigator>> WorkerNavigator::create(WorkerGlobalScope& global_scope)
{ {
return global_scope.heap().allocate<WorkerNavigator>(global_scope.realm(), global_scope).release_allocated_value_but_fixme_should_propagate_errors(); return MUST_OR_THROW_OOM(global_scope.heap().allocate<WorkerNavigator>(global_scope.realm(), global_scope));
} }
WorkerNavigator::WorkerNavigator(WorkerGlobalScope& global_scope) WorkerNavigator::WorkerNavigator(WorkerGlobalScope& global_scope)

2
Userland/Libraries/LibWeb/HTML/WorkerNavigator.h
View file

@ -22,7 +22,7 @@ class WorkerNavigator : public Bindings::PlatformObject
WEB_PLATFORM_OBJECT(WorkerNavigator, Bindings::PlatformObject); WEB_PLATFORM_OBJECT(WorkerNavigator, Bindings::PlatformObject);
public: public:
static JS::NonnullGCPtr<WorkerNavigator> create(WorkerGlobalScope&); static WebIDL::ExceptionOr<JS::NonnullGCPtr<WorkerNavigator>> create(WorkerGlobalScope&);
virtual ~WorkerNavigator() override; virtual ~WorkerNavigator() override;