RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:07:36 +00:00
Code Issues Activity Actions

Meta: Disable PVS Studio v1052 static analysis rule in github actions

Browse source 
This rule conflicts with the projects style guide, and ends up being
just a bunch of unnecessary noise. So lets just suppress it.
This commit is contained in:
Brian Gianforcaro 2022-12-28 15:03:30 -08:00 • committed by Andreas Kling
parent 7dc0edcb86
commit 19a87fce36
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
.github/workflows/pvs-studio-static-analysis.yml vendored
View file

@ -124,11 +124,14 @@ jobs:
# Our TRY(..) macro seems to breaks this rule and trigger weird behavior in PVS Studio. # Our TRY(..) macro seems to breaks this rule and trigger weird behavior in PVS Studio.
# #
# - v677: Custom declaration of a standard '<example>' type. The declaration from system header files should be used instead. # - v677: Custom declaration of a standard '<example>' type. The declaration from system header files should be used instead.
# This rule doesn't make sense for Serenity, as We are the system headers. # This rule doesn't make sense for Serenity, as we are the system headers.
# #
# - v1061: Extending the 'std' namespace may result in undefined behavior. # - v1061: Extending the 'std' namespace may result in undefined behavior.
# We have no choice, some features of C++ require us to. # We have no choice, some features of C++ require us to.
# #
# - V1052: Declaring virtual methods in a class marked as 'final' is pointless.
# This rule contradicts the serenity style rules.
#
# - False Positives: # - False Positives:
# v591: Non-void function should return a value. # v591: Non-void function should return a value.
# v603: Object was created but is not being used. # v603: Object was created but is not being used.
@ -138,7 +141,7 @@ jobs:
- name: Filter PVS Log - name: Filter PVS Log
working-directory: ${{ github.workspace }}/Build/${{ env.PVS_STUDIO_ANALYSIS_ARCH }} working-directory: ${{ github.workspace }}/Build/${{ env.PVS_STUDIO_ANALYSIS_ARCH }}
run: | run: |
pvs-studio-analyzer suppress -v530 -v591 -v603 -v677 -v1047 -v1061 -v1076 project.plog pvs-studio-analyzer suppress -v530 -v591 -v603 -v677 -v1047 -v1052 -v1061 -v1076 project.plog
pvs-studio-analyzer filter-suppressed project.plog pvs-studio-analyzer filter-suppressed project.plog
- name: Print PVS Log - name: Print PVS Log