From 19ba32651dbe667ae5307ac1a30242ef66d89bc8 Mon Sep 17 00:00:00 2001 From: Hendiadyoin1 Date: Wed, 8 Dec 2021 13:42:21 +0100 Subject: [PATCH] Kernel: Use AK:any_of in PCI::Device capability checks This is equivalent to std::any_of as clang-tidy suggests. --- Kernel/Bus/PCI/Device.cpp | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/Kernel/Bus/PCI/Device.cpp b/Kernel/Bus/PCI/Device.cpp index 66239a426e..058503a133 100644 --- a/Kernel/Bus/PCI/Device.cpp +++ b/Kernel/Bus/PCI/Device.cpp @@ -4,6 +4,7 @@ * SPDX-License-Identifier: BSD-2-Clause */ +#include #include #include @@ -17,19 +18,15 @@ Device::Device(Address address) bool Device::is_msi_capable() const { - for (const auto& capability : PCI::get_device_identifier(pci_address()).capabilities()) { - if (capability.id().value() == PCI::Capabilities::ID::MSI) - return true; - } - return false; + return AK::any_of( + PCI::get_device_identifier(pci_address()).capabilities(), + [](auto const& capability) { return capability.id().value() == PCI::Capabilities::ID::MSI; }); } bool Device::is_msix_capable() const { - for (const auto& capability : PCI::get_device_identifier(pci_address()).capabilities()) { - if (capability.id().value() == PCI::Capabilities::ID::MSIX) - return true; - } - return false; + return AK::any_of( + PCI::get_device_identifier(pci_address()).capabilities(), + [](auto const& capability) { return capability.id().value() == PCI::Capabilities::ID::MSIX; }); } void Device::enable_pin_based_interrupts() const