From 19c492e976ca51f935dde865d1555e4c378ddf96 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 18 Sep 2021 20:07:38 +0200 Subject: [PATCH] LibWeb: Avoid unnecessary padded_rect() call in Box::paint() We were computing the padded rect of the box during every paint phase, despite only needing it in the Overlay phase. Since this is an expensive call, let's take care not to make it unnecessarily. --- Userland/Libraries/LibWeb/Layout/Box.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/Layout/Box.cpp b/Userland/Libraries/LibWeb/Layout/Box.cpp index 1f51f1a48b..a768702792 100644 --- a/Userland/Libraries/LibWeb/Layout/Box.cpp +++ b/Userland/Libraries/LibWeb/Layout/Box.cpp @@ -28,8 +28,6 @@ void Box::paint(PaintContext& context, PaintPhase phase) if (is_fixed_position()) context.painter().translate(context.scroll_offset()); - auto padded_rect = this->padded_rect(); - if (phase == PaintPhase::Background) { paint_background(context); paint_box_shadow(context); @@ -50,7 +48,7 @@ void Box::paint(PaintContext& context, PaintPhase phase) margin_rect.set_height(height() + margin_box.top + margin_box.bottom); context.painter().draw_rect(enclosing_int_rect(margin_rect), Color::Yellow); - context.painter().draw_rect(enclosing_int_rect(padded_rect), Color::Cyan); + context.painter().draw_rect(enclosing_int_rect(padded_rect()), Color::Cyan); context.painter().draw_rect(enclosing_int_rect(content_rect), Color::Magenta); }