RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 21:47:45 +00:00
Code Issues Activity Actions

LibC+Everywhere: Remove open_with_path_length() in favor of open()

Browse source 
This API was a mostly gratuitous deviation from POSIX that gave up some
portability in exchange for avoiding the occasional strlen().

I don't think that was actually achieving anything valuable, so let's
just chill out and have the same open() API as everyone else. :^)
This commit is contained in:
Andreas Kling 2021-01-12 19:21:59 +01:00
parent d551263b11
commit 1a08ac72ad
21 changed files with 51 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

16
AK/Platform.h
View file

@ -67,22 +67,6 @@
#ifndef __serenity__
# define PAGE_SIZE sysconf(_SC_PAGESIZE)
# include <errno.h>
# include <fcntl.h>
# include <stdlib.h>
# include <string.h>
inline int open_with_path_length(const char* path, size_t path_length, int options, mode_t mode)
{
auto* tmp = (char*)malloc(path_length + 1);
memcpy(tmp, path, path_length);
tmp[path_length] = '\0';
int fd = open(tmp, options, mode);
int saved_errno = errno;
free(tmp);
errno = saved_errno;
return fd;
}
#endif
ALWAYS_INLINE int count_trailing_zeroes_32(unsigned int val)