mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 10:37:44 +00:00
LibC+Everywhere: Remove open_with_path_length() in favor of open()
This API was a mostly gratuitous deviation from POSIX that gave up some portability in exchange for avoiding the occasional strlen(). I don't think that was actually achieving anything valuable, so let's just chill out and have the same open() API as everyone else. :^)
This commit is contained in:
parent
d551263b11
commit
1a08ac72ad
21 changed files with 51 additions and 69 deletions
|
@ -98,12 +98,12 @@ void HexEditor::set_position(int position)
|
|||
update_status();
|
||||
}
|
||||
|
||||
bool HexEditor::write_to_file(const StringView& path)
|
||||
bool HexEditor::write_to_file(const String& path)
|
||||
{
|
||||
if (m_buffer.is_empty())
|
||||
return true;
|
||||
|
||||
int fd = open_with_path_length(path.characters_without_null_termination(), path.length(), O_WRONLY | O_CREAT | O_TRUNC, 0666);
|
||||
int fd = open(path.characters(), O_WRONLY | O_CREAT | O_TRUNC, 0666);
|
||||
if (fd < 0) {
|
||||
perror("open");
|
||||
return false;
|
||||
|
|
|
@ -51,7 +51,7 @@ public:
|
|||
|
||||
void set_buffer(const ByteBuffer&);
|
||||
void fill_selection(u8 fill_byte);
|
||||
bool write_to_file(const StringView& path);
|
||||
bool write_to_file(const String& path);
|
||||
|
||||
bool has_selection() const { return !(m_selection_start == -1 || m_selection_end == -1 || (m_selection_end - m_selection_start) < 0 || m_buffer.is_empty()); }
|
||||
bool copy_selected_text_to_clipboard();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue