RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 16:28:11 +00:00
Code Issues Activity Actions

LibWeb: Expose SVGCircleElement attributes to JS

Browse source
This commit is contained in:
Sam Atkins 2022-03-22 16:37:16 +00:00 • committed by Andreas Kling
parent b51ea3a67c
commit 1a3d6c68ef
3 changed files with 39 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Userland/Libraries/LibWeb/SVG/SVGCircleElement.cpp
View file

@ -70,4 +70,34 @@ Gfx::Path& SVGCircleElement::get_path()
return m_path.value();
}
// https://www.w3.org/TR/SVG11/shapes.html#CircleElementCXAttribute
NonnullRefPtr<SVGAnimatedLength> SVGCircleElement::cx() const
{
// FIXME: Populate the unit type when it is parsed (0 here is "unknown").
// FIXME: Create a proper animated value when animations are supported.
auto base_length = SVGLength::create(0, m_center_x.value_or(0));
auto anim_length = SVGLength::create(0, m_center_x.value_or(0));
return SVGAnimatedLength::create(move(base_length), move(anim_length));
}
// https://www.w3.org/TR/SVG11/shapes.html#CircleElementCYAttribute
NonnullRefPtr<SVGAnimatedLength> SVGCircleElement::cy() const
{
// FIXME: Populate the unit type when it is parsed (0 here is "unknown").
// FIXME: Create a proper animated value when animations are supported.
auto base_length = SVGLength::create(0, m_center_y.value_or(0));
auto anim_length = SVGLength::create(0, m_center_y.value_or(0));
return SVGAnimatedLength::create(move(base_length), move(anim_length));
}
// https://www.w3.org/TR/SVG11/shapes.html#CircleElementRAttribute
NonnullRefPtr<SVGAnimatedLength> SVGCircleElement::r() const
{
// FIXME: Populate the unit type when it is parsed (0 here is "unknown").
// FIXME: Create a proper animated value when animations are supported.
auto base_length = SVGLength::create(0, m_radius.value_or(0));
auto anim_length = SVGLength::create(0, m_radius.value_or(0));
return SVGAnimatedLength::create(move(base_length), move(anim_length));
}
}

5
Userland/Libraries/LibWeb/SVG/SVGCircleElement.h
View file

@ -6,6 +6,7 @@
#pragma once
#include <LibWeb/SVG/SVGAnimatedLength.h>
#include <LibWeb/SVG/SVGGeometryElement.h>
namespace Web::SVG {
@ -21,6 +22,10 @@ public:
virtual Gfx::Path& get_path() override;
NonnullRefPtr<SVGAnimatedLength> cx() const;
NonnullRefPtr<SVGAnimatedLength> cy() const;
NonnullRefPtr<SVGAnimatedLength> r() const;
private:
Optional<Gfx::Path> m_path;

7
Userland/Libraries/LibWeb/SVG/SVGCircleElement.idl
View file

@ -1,8 +1,9 @@
#import <SVG/SVGAnimatedLength.idl>
#import <SVG/SVGGeometryElement.idl>
[Exposed=Window]
interface SVGCircleElement : SVGGeometryElement {
// [SameObject] readonly attribute SVGAnimatedLength cx;
// [SameObject] readonly attribute SVGAnimatedLength cy;
// [SameObject] readonly attribute SVGAnimatedLength r;
[SameObject] readonly attribute SVGAnimatedLength cx;
[SameObject] readonly attribute SVGAnimatedLength cy;
[SameObject] readonly attribute SVGAnimatedLength r;
};