RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:38:12 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibWebSocket

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-04 14:08:30 -07:00 • committed by Andreas Kling
parent 8b334248e4
commit 1a59cffb00
4 changed files with 6 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWebSocket/Impl/WebSocketImpl.cpp
View file

@ -1,6 +1,7 @@
/* /*
* Copyright (c) 2021, Dex♪ <dexes.ttp@gmail.com> * Copyright (c) 2021, Dex♪ <dexes.ttp@gmail.com>
* Copyright (c) 2022, Ali Mohammad Pur <mpfard@serenityos.org> * Copyright (c) 2022, Ali Mohammad Pur <mpfard@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -14,10 +15,6 @@ WebSocketImpl::WebSocketImpl(Core::Object* parent)
{ {
} }
WebSocketImpl::~WebSocketImpl()
{
}
void WebSocketImpl::connect(ConnectionInfo const& connection_info) void WebSocketImpl::connect(ConnectionInfo const& connection_info)
{ {
VERIFY(!m_socket); VERIFY(!m_socket);

3
Userland/Libraries/LibWebSocket/Impl/WebSocketImpl.h
View file

@ -1,6 +1,7 @@
/* /*
* Copyright (c) 2021, Dex♪ <dexes.ttp@gmail.com> * Copyright (c) 2021, Dex♪ <dexes.ttp@gmail.com>
* Copyright (c) 2022, Ali Mohammad Pur <mpfard@serenityos.org> * Copyright (c) 2022, Ali Mohammad Pur <mpfard@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -19,7 +20,7 @@ class WebSocketImpl : public Core::Object {
C_OBJECT(WebSocketImpl); C_OBJECT(WebSocketImpl);
public: public:
virtual ~WebSocketImpl() override; virtual ~WebSocketImpl() override = default;
explicit WebSocketImpl(Core::Object* parent = nullptr); explicit WebSocketImpl(Core::Object* parent = nullptr);
void connect(ConnectionInfo const&); void connect(ConnectionInfo const&);

5
Userland/Libraries/LibWebSocket/WebSocket.cpp
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2021, Dex♪ <dexes.ttp@gmail.com> * Copyright (c) 2021, Dex♪ <dexes.ttp@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -25,10 +26,6 @@ WebSocket::WebSocket(ConnectionInfo connection)
{ {
} }
WebSocket::~WebSocket()
{
}
void WebSocket::start() void WebSocket::start()
{ {
VERIFY(m_state == WebSocket::InternalState::NotStarted); VERIFY(m_state == WebSocket::InternalState::NotStarted);

3
Userland/Libraries/LibWebSocket/WebSocket.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2021, Dex♪ <dexes.ttp@gmail.com> * Copyright (c) 2021, Dex♪ <dexes.ttp@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -25,7 +26,7 @@ class WebSocket final : public Core::Object {
C_OBJECT(WebSocket) C_OBJECT(WebSocket)
public: public:
static NonnullRefPtr<WebSocket> create(ConnectionInfo); static NonnullRefPtr<WebSocket> create(ConnectionInfo);
virtual ~WebSocket() override; virtual ~WebSocket() override = default;
URL const& url() const { return m_connection.url(); } URL const& url() const { return m_connection.url(); }