mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 08:47:44 +00:00
LibJS: Generify the garbage collector's weak container notifications
This will allow us to use the same interface for other JS weak containers like the WeakMap & WeakRef.
This commit is contained in:
parent
06fdc26656
commit
1a8ee5d8d7
6 changed files with 51 additions and 17 deletions
31
Userland/Libraries/LibJS/Runtime/WeakContainer.h
Normal file
31
Userland/Libraries/LibJS/Runtime/WeakContainer.h
Normal file
|
@ -0,0 +1,31 @@
|
|||
/*
|
||||
* Copyright (c) 2021, Idan Horowitz <idan.horowitz@serenityos.org>
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <LibJS/Heap/Heap.h>
|
||||
|
||||
namespace JS {
|
||||
|
||||
class WeakContainer {
|
||||
public:
|
||||
explicit WeakContainer(Heap& heap)
|
||||
: m_heap(heap)
|
||||
{
|
||||
m_heap.did_create_weak_container({}, *this);
|
||||
}
|
||||
virtual ~WeakContainer()
|
||||
{
|
||||
m_heap.did_destroy_weak_container({}, *this);
|
||||
}
|
||||
|
||||
virtual void remove_sweeped_cells(Badge<Heap>, Vector<Cell*>&) = 0;
|
||||
|
||||
private:
|
||||
Heap& m_heap;
|
||||
};
|
||||
|
||||
}
|
|
@ -15,13 +15,12 @@ WeakSet* WeakSet::create(GlobalObject& global_object)
|
|||
|
||||
WeakSet::WeakSet(Object& prototype)
|
||||
: Object(prototype)
|
||||
, WeakContainer(heap())
|
||||
{
|
||||
heap().did_create_weak_set({}, *this);
|
||||
}
|
||||
|
||||
WeakSet::~WeakSet()
|
||||
{
|
||||
heap().did_destroy_weak_set({}, *this);
|
||||
}
|
||||
|
||||
void WeakSet::remove_sweeped_cells(Badge<Heap>, Vector<Cell*>& cells)
|
||||
|
|
|
@ -9,10 +9,13 @@
|
|||
#include <AK/HashTable.h>
|
||||
#include <LibJS/Runtime/GlobalObject.h>
|
||||
#include <LibJS/Runtime/Object.h>
|
||||
#include <LibJS/Runtime/WeakContainer.h>
|
||||
|
||||
namespace JS {
|
||||
|
||||
class WeakSet : public Object {
|
||||
class WeakSet final
|
||||
: public Object
|
||||
, public WeakContainer {
|
||||
JS_OBJECT(WeakSet, Object);
|
||||
|
||||
public:
|
||||
|
@ -24,7 +27,7 @@ public:
|
|||
HashTable<Cell*> const& values() const { return m_values; };
|
||||
HashTable<Cell*>& values() { return m_values; };
|
||||
|
||||
void remove_sweeped_cells(Badge<Heap>, Vector<Cell*>&);
|
||||
virtual void remove_sweeped_cells(Badge<Heap>, Vector<Cell*>&) override;
|
||||
|
||||
private:
|
||||
HashTable<Cell*> m_values; // This stores Cell pointers instead of Object pointers to aide with sweeping
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue