mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 15:47:44 +00:00
LibGUI: Make Application
's construction fallible
The pattern to construct `Application` was to use the `try_create` method from the `C_OBJECT` macro. While being safe from an OOM perspective, this method doesn't propagate errors from the constructor. This patch make `Application` use the `C_OBJECT_ABSTRACT` and manually define a `create` method that can bubble up errors from the construction stage. This commit also removes the ability to use `argc` and `argv` to create an `Application`, only `Main`'s `Arguments` can be used. From a user point of view, the patch renames `try_create` => `create`, hence the huge number of modified files.
This commit is contained in:
parent
f132751fae
commit
1a97382305
93 changed files with 121 additions and 118 deletions
|
@ -33,7 +33,7 @@ ErrorOr<int> serenity_main(Main::Arguments args)
|
|||
parser.add_positional_argument(adapter, "Adapter to display settings for", "adapter", Core::ArgsParser::Required::No);
|
||||
parser.parse(args);
|
||||
|
||||
auto app = TRY(GUI::Application::try_create(args));
|
||||
auto app = TRY(GUI::Application::create(args));
|
||||
|
||||
if (getuid() != 0) {
|
||||
GUI::MessageBox::show_error(nullptr, "You need to be root to run Network Settings!"sv);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue