1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:37:45 +00:00

LibGUI: Make Application's construction fallible

The pattern to construct `Application` was to use the `try_create`
method from the `C_OBJECT` macro. While being safe from an OOM
perspective, this method doesn't propagate errors from the constructor.
This patch make `Application` use the `C_OBJECT_ABSTRACT` and manually
define a `create` method that can bubble up errors from the
construction stage.

This commit also removes the ability to use `argc` and `argv` to
create an `Application`, only `Main`'s `Arguments` can be used.

From a user point of view, the patch renames `try_create` => `create`,
hence the huge number of modified files.
This commit is contained in:
Lucas CHOLLET 2023-05-05 00:24:53 -04:00 committed by Sam Atkins
parent f132751fae
commit 1a97382305
93 changed files with 121 additions and 118 deletions

View file

@ -22,11 +22,13 @@
namespace GUI {
class Application : public Core::Object {
C_OBJECT(Application);
C_OBJECT_ABSTRACT(Application);
public:
static Application* the();
static ErrorOr<NonnullRefPtr<Application>> create(Main::Arguments const& arguments);
~Application();
static bool in_teardown();
@ -97,11 +99,7 @@ public:
void register_recent_file_actions(Badge<GUI::Menu>, Vector<NonnullRefPtr<GUI::Action>>);
private:
Application(int argc, char** argv);
Application(Main::Arguments const& arguments)
: Application(arguments.argc, arguments.argv)
{
}
Application() = default;
virtual void event(Core::Event&) override;