1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:57:35 +00:00

Kernel: Stop supporting sprintf

The kernel no longer needs sprintf (which might, in theory, overflow),
so we can hide the C++ declaration and make the function uncallable
from within the kernel.

However, libstdc++ still links against it, as libstdc++ uses it for
demangling, from AK::demangle().
This commit is contained in:
Ben Wiederhake 2020-08-16 15:59:36 +02:00 committed by Andreas Kling
parent 04f494fc44
commit 1aad0f8b16
2 changed files with 4 additions and 1 deletions

View file

@ -133,6 +133,10 @@ static void buffer_putch(char*& bufptr, char ch)
*bufptr++ = ch; *bufptr++ = ch;
} }
// Declare it, so that the symbol is exported, because libstdc++ uses it.
// However, *only* libstdc++ uses it, and none of the rest of the Kernel.
extern "C" int sprintf(char* buffer, const char* fmt, ...);
int sprintf(char* buffer, const char* fmt, ...) int sprintf(char* buffer, const char* fmt, ...)
{ {
ScopedSpinLock lock(s_log_lock); ScopedSpinLock lock(s_log_lock);

View file

@ -33,7 +33,6 @@ int dbgprintf(const char* fmt, ...);
int dbgputstr(const char*, int); int dbgputstr(const char*, int);
int kernelputstr(const char*, int); int kernelputstr(const char*, int);
int kprintf(const char* fmt, ...); int kprintf(const char* fmt, ...);
int sprintf(char* buf, const char* fmt, ...);
int snprintf(char* buf, size_t, const char* fmt, ...); int snprintf(char* buf, size_t, const char* fmt, ...);
void set_serial_debug(bool on_or_off); void set_serial_debug(bool on_or_off);
int get_serial_debug(); int get_serial_debug();